This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1058511 - Clear Gecko HTTP cache before checking free cache space. r=gerard-majax #71
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pehrsons
force-pushed
the
b2g-4.4.2_r1_bug1058511
branch
from
a46dc91
to
33f8b2b
Compare
| @@ -652,6 +652,12 @@ def WriteIncrementalOTAPackage(target_zip, source_zip, output_zip): | |||
| script.SetProgress(so_far / total_verify_size) | |||
|
|
|||
| if patch_list or updating_recovery or updating_boot: | |||
| # We clear Gecko's HTTP cache before the regular space check. Even though | |||
| # CacheFreeSpaceCheck() clears files to free up the desired space, the | |||
| # Gecko HTTP cache is not seen as safe to delete and won't be touched. | |||
There was a problem hiding this comment.
I don't follow this line - you say HTTP cache won't be touched, but on other two lines you completely wipe it, so where is the truth?
There was a problem hiding this comment.
Yeah, you really have to read it to the letter. :)
CacheFreeSpaceCheck() does not dare to touch gecko's cache, but we can do it manually.
I'll try to clarify this sentence before checking in, thanks!
Pehrsons
force-pushed
the
b2g-4.4.2_r1_bug1058511
branch
from
33f8b2b
to
15d99e1
Compare
Pehrsons
force-pushed
the
b2g-4.4.2_r1_bug1058511
branch
from
15d99e1
to
fede904
Compare
Pehrsons
changed the title
rvandermeulen
added a commit
that referenced
this pull request
Sep 4, 2014
Bug 1058511 - Clear Gecko HTTP cache before checking free cache space. r=gerard-majax
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.