This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1130271: Call |add_fd_to_epoll_loop| directly in |add_timer|. Remove |remove_timer|. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * function will remove the timer from the I/O loop and cleanup its | ||
| * resources. | ||
| * To remove an existing timer, call |remove_fd_from_epoll_loop|. The | ||
| * parameter is a timer that has been returned by |add_xxx_timer_to_epoll_loop|. |
There was a problem hiding this comment.
Maybe write |add_{relative,absolute}_timer_to_epoll_loop|.
…ove |remove_timer|.
BruceSunMozilla
force-pushed
the
bug1130271_redundant_timer_callback
branch
from
a2633b2
to
7c74579
Compare
rvandermeulen
added a commit
that referenced
this pull request
Feb 13, 2015
…_callback Bug 1130271: Call |add_fd_to_epoll_loop| directly in |add_timer|. Remove |remove_timer|.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1130271: Call |add_fd_to_epoll_loop| directly in |add_timer|. Remove |remove_timer|.