-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1894968 - Bugzilla - Bug Reminder System #2245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dklawren
commented
May 7, 2024
•
edited
edited
- Add a "Reminder" button to the top of show_bug, gated on group membership
- Clicking on the button takes the user to the Reminders preferences panel with the bug number pre-populated
- If the preferences panel is opened with a bug-id specified and there's a needinfo request targeting the current user, pre-populate the notes field with needinfo from
- Add a Reminders preferences panel; rough mock up:
- Sort reminders by when, soonest first
- the edit screen is self-explanatory; and would include an option to delete the reminder
- Add a panel to the header requests dropdown
- the number of open reminders will not impact the number visible in the badge
- just a panel at the bottom with the number of pending reminders, which links to the user preference panel
- if the user has no reminders, don't show the panel
…hat can use them - Added a button to the top of the bug page that allows setting or removing reminder
- Added script to be executed daily to process current reminders - Created templates for the reminder emails
…r an exact date - Updated email templates - Other fixes and improvements
cgsheeh
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very cool, just need to fix a typo.
extensions/BugModal/web/bug_modal.js
Outdated
query_string += `&bug_id=${BUGZILLA.bug_id}`; | ||
} | ||
if (has_needinfo_from) { | ||
query_string += "¬e=Neeinfo from " + encodeURIComponent(has_needinfo_from); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
query_string += "¬e=Neeinfo from " + encodeURIComponent(has_needinfo_from); | |
query_string += "¬e=Needinfo from " + encodeURIComponent(has_needinfo_from); |
- Add number of reminders to the header badge with outstanding requests
Missed one or two punch list items in the first version but should now be complete. |
cgsheeh
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.