Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1894968 - Bugzilla - Bug Reminder System #2245

Merged
merged 10 commits into from
Jun 5, 2024

Conversation

dklawren
Copy link
Collaborator

@dklawren dklawren commented May 7, 2024

  • Add a "Reminder" button to the top of show_bug, gated on group membership
  • Clicking on the button takes the user to the Reminders preferences panel with the bug number pre-populated
  • If the preferences panel is opened with a bug-id specified and there's a needinfo request targeting the current user, pre-populate the notes field with needinfo from
  • Add a Reminders preferences panel; rough mock up:
          Remind me about bug \[number\]:
    	  (o) In \[integer\] days
    	  ( ) In \[integer\] months
    	  ( ) On \[date picker\] (UTC-8)
    	  Note: \[optional single line note\]
    	  (Create Reminder)
    	  ---
    	  Current reminders:
    	       | When     | Created    | Bug                                                     | Note | 
    	  (edit) | tomorrow | 6 days ago | Bug 1217443 - using the skip feature is quite confusing | …    |
  • Sort reminders by when, soonest first
  • the edit screen is self-explanatory; and would include an option to delete the reminder
  • Add a panel to the header requests dropdown
  • the number of open reminders will not impact the number visible in the badge
  • just a panel at the bottom with the number of pending reminders, which links to the user preference panel
  • if the user has no reminders, don't show the panel

@dklawren dklawren added the WIP label May 7, 2024
dklawren and others added 7 commits May 9, 2024 22:40
…hat can use them

- Added a button to the top of the bug page that allows setting or removing reminder
- Added script to be executed daily to process current reminders
- Created templates for the reminder emails
…r an exact date

- Updated email templates
- Other fixes and improvements
@dklawren dklawren removed the WIP label Jun 4, 2024
@dklawren dklawren requested a review from cgsheeh June 4, 2024 13:57
Copy link
Collaborator

@cgsheeh cgsheeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very cool, just need to fix a typo.

query_string += `&bug_id=${BUGZILLA.bug_id}`;
}
if (has_needinfo_from) {
query_string += "&note=Neeinfo from " + encodeURIComponent(has_needinfo_from);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
query_string += "&note=Neeinfo from " + encodeURIComponent(has_needinfo_from);
query_string += "&note=Needinfo from " + encodeURIComponent(has_needinfo_from);

- Add number of reminders to the header badge with outstanding requests
@dklawren dklawren requested a review from cgsheeh June 4, 2024 21:46
@dklawren
Copy link
Collaborator Author

dklawren commented Jun 4, 2024

Missed one or two punch list items in the first version but should now be complete.

@dklawren dklawren merged commit 04f1216 into mozilla-bteam:master Jun 5, 2024
17 checks passed
@dklawren dklawren deleted the 1894968 branch June 5, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants