filter new orange factor bot email #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanwh
suggested changes
Nov 14, 2018
dylanwh
reviewed
Nov 14, 2018
| if (that.data('shown') === '1') { | ||
| that.data('shown', '0'); | ||
| item.text('Show CC Changes'); | ||
| that.text('Show CC Changes'); |
There was a problem hiding this comment.
When you clicked on the button before it wouldn't toggle the text, it would be stuck on 'Show CC Changes'. Same thing with the Show/Hide Treeherder changes, thought I'd might as well make the quick fix while I was nearby
There was a problem hiding this comment.
Make sure that's in the commit message (not in the summary, just in the body).
(as for the summary, I'm fine with "no bug - correctly collapse orange factor bot comments")
dylanwh
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes filtering the orangefactor bot, before only the old treeherder bot was being filtered. (I guess this has been a bug for years)