Skip to content

Commit

Permalink
Update to reflect that we no longer mirror BMO flags.
Browse files Browse the repository at this point in the history
Reviewers: zalun

Reviewed By: zalun

Differential Revision: https://phabricator.services.mozilla.com/D8681
  • Loading branch information
Mark Cote committed Oct 15, 2018
1 parent a7c4ffb commit a47d35f
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions phabricator-user.rst
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -396,15 +396,15 @@ redirects to Differential if the attachment link is clicked.
Review flags
============

For simplicity, and since Differential's review system does not map
cleanly to BMO's review flags, r+ flags, and only r+ flags, are set on
the stub attachment associated with a Differential revision when a
Phabricator user performs an "Accept Revision" action. The flag is
removed if the reviewer later issues a "Request Changes" or a "Resign
as Reviewer" action. Similarly, all r+ flags are removed if the
author selects any of the "Plan Changes", "Request Review", or
"Abandon Revision" actions. In the last case, the stub attachment is
also be obsoleted.
Review flags are not set on Differential stub attachments. The
difference in models between the two systems make any such mapping
both difficult and potentially misleading, the requisite information
is not exposed via Phabricator's Conduit API, and Phacility have
informed us that Differential's models may be changing.

We will, however, display some revision metadata in associated
bugs; see `bug 1489706
<https://bugzilla.mozilla.org/show_bug.cgi?id=1489706>`_.

******************
Using git-cinnabar
Expand Down

0 comments on commit a47d35f

Please sign in to comment.