Skip to content

Commit

Permalink
arc docs: correct the instructions on landing a revision
Browse files Browse the repository at this point in the history
Summary:
I incorrectly assumed that `arc land --revision D123` would pull D123
from Phabricator and land that. This is incorrect - arc land lands the
locally checked out work (or another local branch if a ref is given) in git.
`arc patch D123` then `arc land` is the correct process.

Test Plan: Confirm the docs are correct and check grammer.

Reviewers: mcote

Reviewed By: mcote

Differential Revision: https://phabricator.services.mozilla.com/D190
  • Loading branch information
purelogiq committed Nov 6, 2017
1 parent c8d8cc4 commit f2b4d25
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion phabricator-user.rst
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,8 @@ and to communicate what they should do next. These actions include:
Landing Patches
***************

Landing to git repositories is simple: ``arc land --revision D123``. arc
Landing to git repositories is simple: ``arc patch D123`` (assuming that the
most recent version is not already checked out locally) then ``arc land``. arc
will apply the revision on top of the master branch and push to the remote
origin, assuming you have permission. You can override the "master" branch with
the ``--onto`` flag and you can override the remote origin with the ``--remote``
Expand Down

0 comments on commit f2b4d25

Please sign in to comment.