Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: land commits using sec-approval commit messages (bug 1569209) #87

Merged

Conversation

mars-f
Copy link
Contributor

@mars-f mars-f commented Oct 20, 2019

When a user requests landing of a commit that has an alternate commit
message going through the sec-approval process use that alternate sanitized
commit title and commit summary as the commit's title and summary.

@mars-f mars-f force-pushed the mars/land_commits_with_secure_message branch 3 times, most recently from 26cf437 to f274b37 Compare October 24, 2019 22:45
@mars-f mars-f changed the base branch from master to mars/api_returns_alt_commit_message October 24, 2019 22:46
Copy link
Contributor

@purelogiq purelogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, might do some deeper testing later but don't wanna block this.

@mars-f mars-f changed the base branch from mars/api_returns_alt_commit_message to master October 31, 2019 17:32
When a user requests landing of a commit that has an alternate commit
message going through the sec-approval process use that alternate
sanitized commit title and commit summary as the commit's title and
summary.
@mars-f mars-f force-pushed the mars/land_commits_with_secure_message branch from f274b37 to 8be9c0f Compare October 31, 2019 20:03
@mars-f
Copy link
Contributor Author

mars-f commented Oct 31, 2019

rebase

@mars-f mars-f merged commit 24d9137 into mozilla-conduit:master Nov 1, 2019
@mars-f mars-f deleted the mars/land_commits_with_secure_message branch November 1, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants