Conversation
f9df007
to
1e47d73
Compare
Uh oh! Looks like an error! DetailsClient ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
Co-authored-by: Peter deHaan <peter@deseloper.com>
b5a5435
to
427bde2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't build+run this locally, but code "looks" good.
I can blind R+ if needed, as long as we have Softvision or somebody that can install the add-on and run the gauntlet of tests (Windows, High Contrast, etc).
@pdehaan Softvision will indeed be running the guantlet so if you're comfortable blind R+ing that would be fantastic although actually not entirely necessary since they can use the TaskCluster builds triggered by this PR and locally built XPIs. We're not blocked on merging so your call! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:yolo:
This PR: