Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Add sunset notification to popup UI #985

Merged
merged 7 commits into from May 10, 2023
Merged

Add sunset notification to popup UI #985

merged 7 commits into from May 10, 2023

Conversation

lesleyjanenorton
Copy link
Member

@lesleyjanenorton lesleyjanenorton commented Apr 26, 2023

This PR:

  • Adds messaging about the FPN sunset to all panels of the FPN extension
  • Changes the badge icon to a persistent warning icon
  • Updates the version number to "25.0.0", though this is overwritten somewhere in TaskCluster
  • Stops redirecting folks to the exit survey when the extension is uninstalled
  • Still negotiating with the tests on my M1. This updates one test but is possibly failing others.

src/popup/popup.css Outdated Show resolved Hide resolved
@firefoxci-taskcluster
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:xpi-level-1/QItjqAtVQ2Ky-EWDM-kMkA/dtn12h_4S3qJAulnJu-MWQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:xpi-level-1/QItjqAtVQ2Ky-EWDM-kMkA"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:xpi-level-1/QItjqAtVQ2Ky-EWDM-kMkA/dtn12h_4S3qJAulnJu-MWQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:xpi-level-1/QItjqAtVQ2Ky-EWDM-kMkA"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-05-01T17:19:24.021Z

@lesleyjanenorton lesleyjanenorton changed the title // WIP // Add sunset notification to popup UI Add sunset notification to popup UI May 1, 2023
@lesleyjanenorton lesleyjanenorton marked this pull request as ready for review May 1, 2023 19:33
Copy link
Collaborator

@pdehaan pdehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't build+run this locally, but code "looks" good.
I can blind R+ if needed, as long as we have Softvision or somebody that can install the add-on and run the gauntlet of tests (Windows, High Contrast, etc).

test/extension.js Show resolved Hide resolved
src/background/ui.js Outdated Show resolved Hide resolved
@lesleyjanenorton
Copy link
Member Author

@pdehaan Softvision will indeed be running the guantlet so if you're comfortable blind R+ing that would be fantastic although actually not entirely necessary since they can use the TaskCluster builds triggered by this PR and locally built XPIs. We're not blocked on merging so your call!

Copy link
Collaborator

@pdehaan pdehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:yolo:

@lesleyjanenorton lesleyjanenorton merged commit 72396f4 into master May 10, 2023
8 of 9 checks passed
@lesleyjanenorton lesleyjanenorton deleted the sunset branch May 10, 2023 03:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants