Fixes #275: Convert AboutCompat.jsm to an ES module. #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard8
commented
Sep 12, 2023
Comment on lines
-9
to
-11
| const Services = | ||
| globalThis.Services || | ||
| ChromeUtils.import("resource://gre/modules/Services.jsm").Services; |
There was a problem hiding this comment.
Just to note: Services has been a global in Extension APIs for a while now, and shouldn't be necessary to be manually imported:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts AboutCompat.jsm to an ES module and changes the necessary support infrastructure.
I have not tested it on android, so I'm not certain it will work there. Performing the export on desktop and running the tests seems to work fine.