Skip to content
This repository has been archived by the owner on Apr 3, 2021. It is now read-only.

Breaking: Migrate to material-ui v4 #68

Merged
merged 7 commits into from Nov 13, 2019
Merged

Breaking: Migrate to material-ui v4 #68

merged 7 commits into from Nov 13, 2019

Conversation

edil-it-them
Copy link
Contributor

Closes #67

@edil-it-them
Copy link
Contributor Author

@helfi92, should I change test snapshot files?

helfi92
helfi92 reviewed Oct 30, 2019
View reviewed changes
Copy link
Contributor

@helfi92 helfi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is perfect :)

package.json Outdated Show resolved Hide resolved
src/components/Code/index.jsx Outdated Show resolved Hide resolved
src/components/ErrorPanel/index.jsx Outdated Show resolved Hide resolved
src/theme.js Outdated Show resolved Hide resolved
helfi92
helfi92 approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@helfi92 helfi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohoo, looks awesome! The only thing missing is to update the test snapshots :)

helfi92
helfi92 reviewed Nov 1, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
helfi92
helfi92 approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@helfi92 helfi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@helfi92 helfi92 changed the title Migrate to material-ui v4 Breaking: Migrate to material-ui v4 Nov 13, 2019
helfi92
helfi92 approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@helfi92 helfi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@helfi92 helfi92 merged commit 5f4a18a into mozilla-frontend-infra:master Nov 13, 2019
@helfi92
Copy link
Contributor

helfi92 commented Nov 13, 2019

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@helfi92 helfi92 helfi92 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to material-ui v4
2 participants
@edil-it-them @helfi92