Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting benchmark causes chart resize (and page crash) #177

Closed
sidvishnoi opened this issue Aug 1, 2019 · 3 comments · Fixed by #180
Closed

Selecting benchmark causes chart resize (and page crash) #177

sidvishnoi opened this issue Aug 1, 2019 · 3 comments · Fixed by #180

Comments

@sidvishnoi
Copy link
Collaborator

When selecting a benchmark through the select menu, all the charts get resized (unintended). Selecting benchmark multiple times causes the entire page to crash eventually.
See this video recording on resize behavior: https://streamable.com/g33te
As can be seen in the recording, when the select menu is opened, the body scrollbar disappears, triggering the resize event.

@armenzg
Copy link
Contributor

armenzg commented Aug 7, 2019

Let me know if you have suggestions on how to fix this or if you would like to tackle it.
Perhaps make the containers for each graph have a fix size.

@sidvishnoi
Copy link
Collaborator Author

sidvishnoi commented Aug 7, 2019

Perhaps make the containers for each graph have a fix size.

Yes. Adding size on container would work. But adding a fix size will destroy support for different screen sizes. I think some viewport based unit would be good.

if you would like to tackle it.

Sure. I'll set it up locally and quickly send a PR.

@armenzg
Copy link
Contributor

armenzg commented Aug 8, 2019

Fantastic! Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants