Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenWRT] Port 8080 should redirect to port 4443 #1636

Closed
dhylands opened this issue Feb 6, 2019 · 5 comments
Closed

[OpenWRT] Port 8080 should redirect to port 4443 #1636

dhylands opened this issue Feb 6, 2019 · 5 comments

Comments

@dhylands
Copy link
Contributor

dhylands commented Feb 6, 2019

Currently, when you browse to http://ip-address/ on the Turris Omnia it shows a link to get to the gateway. This is basically a link to http://ip-address:8080

The gateway redirects to https://ip-address/ which is the same page. It should really redirect to https://ip-address:4443

@benfrancis
Copy link
Member

Question: If someone is intentionally accessing the gateway locally via its local IP or .local domain, is there actually much benefit in redirecting them from port 80/8080 to 443/4443 and showing the certificate warning, rather than just using plain HTTP?

@dhylands
Copy link
Contributor Author

dhylands commented Feb 7, 2019

The issue isn't the certificate warning, it's that http://ip-address:80 is currently the main page for the turris omnia router. When the gateway software is installed, it looks like this:
turris-home

So when you click on the gateway if it redirects back to port 80 then you wind up back on the home screen above.

@benfrancis
Copy link
Member

Yes, sorry I understood what you mean I was just asking a more general related question about where we should actually redirect to.

But this is obviously a bug.

@dhylands
Copy link
Contributor Author

dhylands commented Feb 8, 2019

Question: If someone is intentionally accessing the gateway locally via its local IP or .local domain, is there actually much benefit in redirecting them from port 80/8080 to 443/4443 and showing the certificate warning, rather than just using plain HTTP?

Presumably the reason the user is connecting to to the local address is because the internet is down or the tunnel isn't otherwise working. In that light, it probably makes sense to stay on port 8080.

Perhaps http://gateway.local:8080 should not redirect?
And https://gateway.local:8080 should redirect to http://gateway.local:8080

Although, logically, it only makes sense to use https with the tunnel.

Once the tunnel is registered, we should probably rewrite the file that causes the gateway to show up in the photo about to use the tunnel URL.

@mrstegeman
Copy link
Contributor

All we should need to do for this is set the behindForwarding config flag to false.

@mrstegeman mrstegeman changed the title Under OpenWRT https://ip-address:8080 should redirect to port 4443 [OpenWRT] Port 8080 should redirect to port 4443 Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants