Use new intent parser message structure. #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mrstegeman
force-pushed
the
intent-parser
branch
from
8de4555
to
fb8f354
Compare
Codecov Report
@@ Coverage Diff @@
## master #1317 +/- ##
=========================================
+ Coverage 75.12% 75.2% +0.07%
=========================================
Files 123 123
Lines 5974 5989 +15
Branches 839 842 +3
=========================================
+ Hits 4488 4504 +16
Misses 1312 1312
+ Partials 174 173 -1
Continue to review full report at Codecov.
|
mrstegeman
force-pushed
the
intent-parser
branch
11 times, most recently
from
4101a12
to
58e4009
Compare
|
@hobinjk This should be good now. The failures are because the intent-parser change is not yet merged. |
mrstegeman
force-pushed
the
intent-parser
branch
from
58e4009
to
2c3efc4
Compare
|
Now we just have the failing UI test from #1338 |
hobinjk
approved these changes
Sep 6, 2018
mrstegeman
force-pushed
the
intent-parser
branch
2 times, most recently
from
6e2a892
to
139f14a
Compare
mrstegeman
force-pushed
the
intent-parser
branch
from
139f14a
to
a346620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires WebThingsIO/intent-parser#6