Firefox reality quarantine #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Title bar support X-Channel-Revision: [master] mozilla-mobile/android-components@762e069 X-Channel-Revision: [master] mozilla-mobile/fenix@4442139 X-Channel-Revision: [master] mozilla-mobile/firefox-tv@1b30c06 X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@398b433 X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
Also a few fixes for the title bar X-Channel-Revision: [master] mozilla-mobile/android-components@762e069 X-Channel-Revision: [master] mozilla-mobile/fenix@4442139 X-Channel-Revision: [master] mozilla-mobile/firefox-tv@1b30c06 X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@05fb61d X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
X-Channel-Revision: [master] mozilla-mobile/android-components@762e069 X-Channel-Revision: [master] mozilla-mobile/fenix@4442139 X-Channel-Revision: [master] mozilla-mobile/firefox-tv@1b30c06 X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@f3ada54 X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
* History feed * Do not show redirects in the history feed Also avoid storing URLs manually and rely o the history delegate for all history management * Refactor title bar update code * Added support for getVisited and visited links colouring Also fixed an issue with history sections and made the historyListener a delegate as having multiple listeners is not really necessary * Fixed rebase issue * Update history entries when revisited Also fixed history cleanup ranges * Handle dim when history is opened X-Channel-Revision: [master] mozilla-mobile/android-components@762e069 X-Channel-Revision: [master] mozilla-mobile/fenix@4442139 X-Channel-Revision: [master] mozilla-mobile/firefox-tv@1b30c06 X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@d2f07b0 X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
* Update Bookmarks UI * Fixed crash when scrolling X-Channel-Revision: [master] mozilla-mobile/android-components@762e069 X-Channel-Revision: [master] mozilla-mobile/fenix@4442139 X-Channel-Revision: [master] mozilla-mobile/firefox-tv@1b30c06 X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@357f7e1 X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
Delphine
requested changes
Sep 4, 2019
| @@ -885,4 +979,17 @@ | |||
|
|
|||
| <!-- This string is displayed in the content language list in front of the system default language in between parenthesis --> | |||
| <string name="language_default">Default</string> | |||
|
|
|||
| <!-- This string is displayed in the URL bar when the user is in the home page --> | |||
There was a problem hiding this comment.
Please explain what "%1$s" refers to in comment.
CC @keianhzo.
There was a problem hiding this comment.
X-Channel-Revision: [master] mozilla-mobile/android-components@762e069 X-Channel-Revision: [master] mozilla-mobile/fenix@4442139 X-Channel-Revision: [master] mozilla-mobile/firefox-tv@1b30c06 X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@ba0fbd6 X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
X-Channel-Revision: [master] mozilla-mobile/android-components@762e069 X-Channel-Revision: [master] mozilla-mobile/fenix@4442139 X-Channel-Revision: [master] mozilla-mobile/firefox-tv@1b30c06 X-Channel-Converted-Revision: [master] MozillaReality/FirefoxReality@e6ec2b6 X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@4828903
Delphine
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.