Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BitBucket references from Firefox documentation #197

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Conversation

flodolo
Copy link
Contributor

@flodolo flodolo commented Apr 9, 2020

No description provided.

@flodolo flodolo requested a review from a team April 9, 2020 14:44
@flodolo flodolo self-assigned this Apr 9, 2020
Copy link
Contributor

@peiying2 peiying2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One sentence needs to take a second look. Otherwise, it looks good.

* Push at least one change to the repository, otherwise Pontoon will not pick it up during sync. The safest change it to initialize the `toolkit/chrome/global/intl.properties` file with the correct values ([example](https://bitbucket.org/mozilla-l10n/ppl/commits/b3fd0faf59b0b45b2cf30c01d85157beee2a0bd0 )).
* If the locale is not [available](https://pontoon.mozilla.org/teams/) in Pontoon yet, [consult this document](../../tools/pontoon/adding_new_locale.md) for instructions on how to add it.
* File a bug to create a new Mercurial repository in [l10n-central](https://hg.mozilla.org/l10n-central/). Several bug templates, including one to request a new repository, are available in [this page](https://l10n.mozilla.org/bugs/new-locale). For more information about these templates, [refer to this document](adding_nightly.md).
* Push at least one change to the repository, otherwise Pontoon will not pick it up during sync. The safest change it to initialize the `toolkit/chrome/global/intl.properties` file with the correct values ([example](https://hg.mozilla.org/l10n-central/ppl/rev/b3fd0faf59b0b45b2cf30c01d85157beee2a0bd0)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrite the second sentence: The safest way to change it is to ....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like it was already there and missed at least twice.

Copy link
Contributor

@peiying2 peiying2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler change, :). LGTM!

@flodolo
Copy link
Contributor Author

flodolo commented Apr 9, 2020

Thanks!

@flodolo flodolo merged commit f9b6e7a into master Apr 9, 2020
@flodolo flodolo deleted the issue_196 branch April 9, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants