This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Add translateWith #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
suggested changes
Dec 13, 2022
There was a problem hiding this comment.
Luckily I looked at the code, because the string wasn't clear.
title: `${browser.i18n.getMessage("translateWith")} Firefox Translations`,
Never hard-code content and patch together strings.
https://mozilla-l10n.github.io/documentation/localization/dev_best_practices.html#avoid-concatenations-use-placeholders-instead
You need to expose the whole strings.
|
BTW, I've just filed an issue for an hard-coded string ( |
Co-authored-by: Francesco Lodolo <flod@lodolo.net>
|
@flodolo lmk how it looks now |
flodolo
reviewed
Dec 16, 2022
flodolo
approved these changes
Dec 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.