This repository has been archived by the owner on Mar 30, 2019. It is now read-only.
[bug 1267266] Rename locale dirs with dashes to use underscores. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Webstatus is the only other tool involved and should be OK with _, but I'm pretty sure Matjaz needs to manually fix stuff in the DB to maintain attributions. |
|
This should just work in Pontoon. r+ |
|
Thanks, seems to have worked fine on the Input side of things. :D |
|
Pontoon also synced and everything seems fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mathjazz @flodolo r?
I found while investigated bug 1267266 that Input doesn't load translations from locale directories that use a
-in them instead of a_. This change renames all the directories that still have-in them.Pontoon should be able to handle this fine, it looks for both variants when locating resource files. I'm not sure if other tooling we have will break, hence the PR and request for review. Thanks!