Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Derive entry titles from saved login URL #16

Closed
sandysage opened this issue Nov 29, 2018 · 3 comments · Fixed by #68
Closed

Derive entry titles from saved login URL #16

sandysage opened this issue Nov 29, 2018 · 3 comments · Fixed by #68
Assignees
@jaredhirsch

Comments

@sandysage
Copy link

sandysage commented Nov 29, 2018 •
edited by linuxwolf

When viewing the entry list, I want to quickly scan the entry list by title (e.g., Facebook instead of https://www.facebook.com or even www.facebook.com), so I can quickly access my username and password for managing that record.

Acceptance criteria

  • Should be able to view the list of entries by the origin
  • Default alphabetical ordering on the origin should make sense (eg facebook comes before twitter)
  • Should not not include the protocol (http://, https://, www.)
  • Should not see anything after the suffix (.com/{*})
  • Should support future goals of editing the entry name

Requires #21
@jaredhirsch
Copy link
Contributor

  • Should support future goals of editing the entry name

I'm not sure we can make the entry name editable, if we're planning to stick with the existing nsILoginInfo/MetaData interfaces for storage (#21).

@linuxwolf
Copy link
Contributor

  • Should support future goals of editing the entry name

I'm not sure we can make the entry name editable, if we're planning to stick with the existing nsILoginInfo/MetaData interfaces for storage (#21).

Thats why it's a future goal (-:

@linuxwolf
Copy link
Contributor

Consider placing this logic within the browser.logins API implementation, so we can utilize nsURL

@linuxwolf linuxwolf added backlog and removed on-deck labels Jan 14, 2019
@jaredhirsch jaredhirsch self-assigned this Jan 22, 2019
jaredhirsch added a commit to jaredhirsch/lockbox-addon that referenced this issue Jan 26, 2019
@jaredhirsch
Derive entry titles from saved login URL (mozilla-lockwise#16)
da0c9a7 
* Update the hostname-to-title conversion to match the Android implementation:
  https://github.com/mozilla-lockbox/lockbox-android/blob/2669055/app/src/main/java/mozilla/lockbox/model/ModelUtils.kt#L9

* Add unit tests for hostname-to-title conversion.

Fixes mozilla-lockwise#16.
@jaredhirsch jaredhirsch mentioned this issue Jan 26, 2019
Merged
6 tasks
lmorchard pushed a commit that referenced this issue Jan 30, 2019
@jaredhirsch @lmorchard
Derive entry titles from saved login URL (#16) (#68)
8cbd5f2 
* Update the hostname-to-title conversion to match the Android implementation:
  https://github.com/mozilla-lockbox/lockbox-android/blob/2669055/app/src/main/java/mozilla/lockbox/model/ModelUtils.kt#L9

* Add unit tests for hostname-to-title conversion.

Fixes #16.
@ghost ghost removed the in progress label Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaredhirsch jaredhirsch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Derive entry titles from saved login URL (#16) jaredhirsch/lockbox-addon
3 participants
@jaredhirsch @linuxwolf @sandysage