Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Search entries in both management interface and doorhanger #36

Closed
2 of 3 tasks
sandysage opened this issue Dec 14, 2018 · 4 comments · Fixed by #135
Closed
2 of 3 tasks

Search entries in both management interface and doorhanger #36

sandysage opened this issue Dec 14, 2018 · 4 comments · Fixed by #135

Comments

@sandysage
Copy link

sandysage commented Dec 14, 2018

When I have several Lockbox entries and I need to access an online account, I need to be able to quickly find an entry by website address, entry name, or username. Both in the doorhanger and the management interface.

Acceptance criteria

  • Should filter results based on characters entered in the search field
  • Should display matching results by: title, URL, username
  • Should provide additional information to the user if no matching entries are found

Visual Design

Full View
Default (focused): https://zpl.io/boK9ggk
Searching: https://zpl.io/bldPRR5
Not Focused: https://zpl.io/am94zze
No Matching Results*: https://zpl.io/bzAOPkE

Doorhanger
Default(focused): https://zpl.io/2EPeOpy
Searching: https://zpl.io/25G8Jln
Not Focused: https://zpl.io/VQK46qW
No Matching Results*: https://zpl.io/agP3rj9

*Link for no matching results directs here: https://lockbox.firefox.com/faq.html#how-do-i-get-my-saved-logins-into-firefox-lockbox

@linuxwolf linuxwolf added backlog and removed on-deck labels Jan 25, 2019
@sandysage sandysage changed the title Search entries Search entries in both management interface and doorhanger Jan 25, 2019
@jaredhirsch jaredhirsch self-assigned this Jan 29, 2019
@jaredhirsch
Copy link
Contributor

jaredhirsch commented Jan 29, 2019

The search features seem to be in the addon already. Closing. Feel free to reopen if I've missed something 👍

@ghost ghost removed the in progress label Jan 29, 2019
@nickbrandt
Copy link

@6a68 although the functionality of this is already built, there have been some changes in the styling since this was completed for the extension. In addition, there are changes in copy/styling for the No Results when searching. Should I create those as new issues, or would you rather we re-open this issue and adjust it to reflect the work that needs done?

@linuxwolf linuxwolf reopened this Jan 29, 2019
@linuxwolf
Copy link
Contributor

Just about all of search is shared components, so re-opening this issue is best.

@linuxwolf
Copy link
Contributor

linuxwolf commented Mar 4, 2019

Most of the requirements were implemented as part of #76 , leaving only the "No Matching Entries" details to be done.

@ghost ghost removed the in progress label Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants