Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Change isClickable and isEnabled settings to each be their own Consumers #279

Open
devinreams opened this issue Dec 17, 2018 · 0 comments
Open

Change isClickable and isEnabled settings to each be their own Consumers #279

devinreams opened this issue Dec 17, 2018 · 0 comments
Labels
task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. tech-debt
Projects
Lockwise Mobile

Comments

@devinreams
Copy link
Contributor

Follow up debt suggestion from @sashei on this PR:
#232 (comment)

it would be nice for these isClickable and isEnabled settings to each be their own Consumers on the View rather than side effects of showing / hiding the loading spinner. IIRC from iOS, we have other situations (no saved entries comes to mind) where we want to disable the filter / sort buttons.
@devinreams devinreams mentioned this issue Dec 17, 2018
Merged
6 tasks
@devinreams devinreams added the task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. label May 15, 2019
@eliserichards eliserichards added this to Inbox in Lockwise Mobile via automation Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. tech-debt
Projects
Lockwise Mobile
  
Inbox
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devinreams