Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Autofill credentials in web pages #371

Closed
4 tasks done
sashei opened this issue Jan 11, 2019 · 0 comments
Closed
4 tasks done

Autofill credentials in web pages #371

sashei opened this issue Jan 11, 2019 · 0 comments

Comments

@sashei
Copy link
Contributor

sashei commented Jan 11, 2019

Acceptance Criteria

When the AutofillService encounters a FillRequest where the top-level ViewNode is a WebView or GeckoView, optimize credential filling to:

  • use the domain of the displayed URL in the webpage rather than the app package name
  • search for autofill-able views in a web context rather than a native Android app context

Engineering Notes

Documentation

Engineering Tasks

  • Modify ParsedStructure.kt logic to check for WebViews.
  • Use the AssistStructure.ViewNode.getWebDomain() from the WebView node to determine potential credentials
  • Update the username and password keywords to include attributes from the wc3 standard and any encountered or relevant characteristics (more in the autofill docs )
  • Update the architecture/autofill doc with a plaintext writeup of the heuristics that you used

Gotchas

There's likely a high degree of complexity here in doing the webview parsing; I'd guess more so in browsers & web-optimized pages than mobile apps that use WebViews for authentication like we do in Lockbox.

@sashei sashei mentioned this issue Jan 11, 2019
7 tasks
@ghost ghost assigned sashei Jan 11, 2019
@ghost ghost added the in progress label Jan 11, 2019
@sashei sashei removed their assignment Jan 11, 2019
@devinreams devinreams added this to the Android M9 milestone Jan 16, 2019
@devinreams devinreams changed the title Provide credentials in web pages Autofill credentials in web pages Jan 16, 2019
@devinreams devinreams modified the milestones: Android M9, Android M10 Jan 25, 2019
@ghost ghost removed the in progress label Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants