Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Use Sync-backed LoginStorage and Remove test data for release/debug builds #43

Closed
sandysage opened this issue Jul 12, 2018 · 2 comments · Fixed by #221
Closed

Use Sync-backed LoginStorage and Remove test data for release/debug builds #43

sandysage opened this issue Jul 12, 2018 · 2 comments · Fixed by #221

Comments

@sandysage
Copy link

sandysage commented Jul 12, 2018

Actually use the sync keys to get and store data locally and expose in app.

To access my saved logins, I want to safely log into my account and access the common list of entries, confident that my passwords are secure.

Acceptance criteria

Requires #22

@sandysage sandysage added task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. MVP labels Jul 12, 2018
@devinreams devinreams added this to the M5 - Autofill + Sync milestone Oct 11, 2018
@eliserichards eliserichards removed the task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. label Oct 23, 2018
@linuxwolf linuxwolf changed the title Remove test data for Sync-backed Login Storage API Use Sync-backed LoginStorage and Remove test data Nov 1, 2018
@devinreams devinreams added backlog and removed on-deck labels Nov 9, 2018
@devinreams
Copy link
Contributor

Do we need to keep in-memory storage for UI testing only? (we test against real account/data on iOS, very integration-y and heavy) = Yes, keep it and conditionally consider the environment

@devinreams devinreams changed the title Use Sync-backed LoginStorage and Remove test data Use Sync-backed LoginStorage and Remove test data for release/debug builds Nov 12, 2018
@sashei
Copy link
Contributor

sashei commented Nov 12, 2018

I added the dependency on #189 because I realized that the interface for the LoginsStorage is also changing as part of that upgrade :p

Removing that dependency, a-c update will follow this story rather than precede it per convo with @linuxwolf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants