This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Fixed Issue #1193: Added space below Lock Now button #1228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
197
to
198
| // Font is not consistent with app. Uncomment this line out if this was intentional | ||
| // cell.textValue.font = UIFont(name: "Menlo-Regular", size: 16) |
There was a problem hiding this comment.
I think these lines can just be deleted 👍
There was a problem hiding this comment.
@eliserichards For some reason I keep getting "build error" for the uispecs test in GitHub. Is that error on my side?
There was a problem hiding this comment.
@Krisjackson no it isn't - figuring it out now. It's an fxa error with our python script that creates fake logins for the main list, I believe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1193
Added space below Lock Now button in settings.
Testing and Review Notes
Go to Settings page. Scroll to bottom on TableView. There should be a space of 18px below the last cell.
Screenshots or Videos