Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Fixed Issue #1193: Added space below Lock Now button #1228

Closed
wants to merge 4 commits into from
Closed

Fixed Issue #1193: Added space below Lock Now button #1228

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94dbeb7
Added space below last cell in Settings
KrisRJack May 19, 2020
8e6b88f
Removed Menlo-Regular font and comments.
KrisRJack May 22, 2020
6eaefdf
Merge branch 'master' into issue#1193
kaylagalway Jun 2, 2020
88166b6
Merge branch 'master' into issue#1193
kaylagalway Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lockbox-ios/View/ItemDetailView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ extension ItemDetailView: UIGestureRecognizerDelegate {
}

if let revealObserver = cellConfiguration.revealPasswordObserver {
cell.textValue.font = UIFont(name: "Menlo-Regular", size: 16)
// Font is not consistent with app. Uncomment this line out if this was intentional
// cell.textValue.font = UIFont(name: "Menlo-Regular", size: 16)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these lines can just be deleted 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eliserichards For some reason I keep getting "build error" for the uispecs test in GitHub. Is that error on my side?

Copy link
Contributor

@kaylagalway kaylagalway Jun 2, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krisjackson no it isn't - figuring it out now. It's an fxa error with our python script that creates fake logins for the main list, I believe


cell.revealButton.rx.tap
.map { _ -> Bool in
Expand Down
1 change: 1 addition & 0 deletions lockbox-ios/View/SettingListView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ extension SettingListView {
footerView.frame = frame

self.tableView.tableFooterView = footerView
self.tableView.contentInset = UIEdgeInsets(top: 0, left: 0, bottom: 18, right: 0)
}
}

Expand Down