Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support embeds of variable height #48

Closed
wilsonpage opened this issue Apr 27, 2016 · 1 comment
Closed

Support embeds of variable height #48

wilsonpage opened this issue Apr 27, 2016 · 1 comment
Assignees
@wilsonpage
Milestone
Sprint 2 [May 2nd...

Comments

@wilsonpage
Copy link
Collaborator

wilsonpage commented Apr 27, 2016 •
edited

Not all embeds have a fixed height. For example I may want to show a list of upcoming buses, if there is only one bus upcoming, I don't want to render a widget tall enough to accommodate three buses. Essentially the content length is variable.

So acheive this we'll need to inject some JS into the webview that can read the height of the document and report it back to the native app so that it can render the webview at the correct height. We may also want to use a mutation observer to monitor for changes.

Communicating JS -> Native is not supported by React Native's WebView component, so we'll likely have to extend it to add this feature.
@oteo oteo added this to the Sprint 2 [May 2nd - 13th] milestone Apr 29, 2016
@wilsonpage wilsonpage self-assigned this Apr 29, 2016
wilsonpage added a commit to wilsonpage/magnet-client that referenced this issue May 4, 2016
@wilsonpage
Implemented custom webview (android) (issue mozilla-magnet#48)
0fd4225
wilsonpage added a commit to wilsonpage/magnet-client that referenced this issue May 4, 2016
@wilsonpage
Implemented custom webview (android) (issue mozilla-magnet#48)
114cdee
arcturus pushed a commit that referenced this issue May 6, 2016
@wilsonpage @arcturus
Implemented custom webview (android) (issue #48) (#65)
6b20a61 
* Implemented custom webview (android) (issue #48)

* Implemented ios custom webview and simplified android manager

* Addressed comments

* Addressed comments
@arcturus arcturus mentioned this issue May 7, 2016
Merged
@arcturus
Copy link
Member

arcturus commented May 7, 2016

Closed by #65

@arcturus arcturus closed this as completed May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilsonpage wilsonpage

Labels
None yet
Projects
None yet
Milestone
Sprint 2 [May 2nd - 13th]
Development

No branches or pull requests
3 participants
@arcturus @wilsonpage @oteo