This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
Issue #61: Support json stats. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcomella
approved these changes
Jan 17, 2020
| result: str = "" | ||
| for date in sorted(calculations.keys()): | ||
| result += date + ", " + calculations[date] + "\n" | ||
| return result | ||
|
|
||
| def calculate(dirname: str, tipe: Type, product: str, result_file: str): | ||
| def json_format_calculations(calculations: Mapping[str, str]) -> str: |
There was a problem hiding this comment.
nit: not worth changing now but this might be safer & more intuitive to do with the built-in json library (which I think can automatically convert python data types to valid JSON strings).
There was a problem hiding this comment.
Very good point. I will definitely do that on a subsequent pass. I honestly didn't expect @ecsmyth would have success with this output so I didn't anticipate using the code as it stands. But, it works and we are going with it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.