Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Allow the feature to notify when to close the tabs tray #11234

Closed
jonalmeida opened this issue Nov 8, 2021 · 0 comments
Closed

Allow the feature to notify when to close the tabs tray #11234

jonalmeida opened this issue Nov 8, 2021 · 0 comments
Assignees
@jonalmeida
Labels
🐞 bug Something isn't working <tabs> Components: browser-tabstray, feature-tabs

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Nov 8, 2021 •
edited by data-sync-user

In #11108, we removed the closeTabsTray callback from the TabsFeature thinking that this wasn't needed any more.

This was only the case for Fenix however and led to bugs in Reference Browser that relied on knowing when the difference between a user-invoked filter and one determined through state changes.

See: mozilla-mobile/reference-browser#1705

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida added 🐞 bug Something isn't working <tabs> Components: browser-tabstray, feature-tabs labels Nov 8, 2021
@jonalmeida jonalmeida self-assigned this Nov 8, 2021
jonalmeida added a commit to jonalmeida/android-components that referenced this issue Nov 8, 2021
@jonalmeida
Close mozilla-mobile#11234: Re-introduce close support in TabsFeature
3d84e87
@jonalmeida jonalmeida changed the title All the feature to notify when to close the tabs tray Allow the feature to notify when to close the tabs tray Nov 8, 2021
@jonalmeida jonalmeida mentioned this issue Nov 8, 2021
Closed
@mergify mergify bot closed this as completed in f8e79c9 Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonalmeida jonalmeida

Labels
🐞 bug Something isn't working <tabs> Components: browser-tabstray, feature-tabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonalmeida