Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Let bot do: Rebase -> All Green? -> Land #1200

Closed
pocmo opened this issue Oct 29, 2018 · 8 comments
Closed

Let bot do: Rebase -> All Green? -> Land #1200

pocmo opened this issue Oct 29, 2018 · 8 comments
Assignees
@pocmo
Labels
automation Build automation, Continuous integration, ..
Projects
A-C: Android Components Sprint Planning
Milestone
9.0.0 📷

Comments

@pocmo
Copy link
Contributor

pocmo commented Oct 29, 2018 •
edited by data-sync-user

It's too time consuming to manually update a PR, check back later and merge or update PR again. It would be much nicer if we could do something like:

  • Add [needs landing] label
  • Bot comes along and:
    • Checks out PR
    • Rebases PR
    • Builds, runs tests etc.
  • If all green: Bot merges PR
  • If red: Bot removes label and comments

There are some existing solutions:

┆Issue is synchronized with this Jira Task
@pocmo pocmo added the automation Build automation, Continuous integration, .. label Oct 29, 2018
@pocmo
Copy link
Contributor Author

pocmo commented Nov 7, 2018

Another option would be to do that from a taskcluster task that is triggered by a hook. We may want to have a build cache first, so that we can build rebased PRs pretty quickly: #638

@jonalmeida
Copy link
Contributor

I'm not particular to either one, but homu might work better with a taskcluster as our custom CI. I'll ask around in the Rust #infra channel if anyone has done this already.

@jonalmeida
Copy link
Contributor

bors can integrate without too much of a problem with any CI that posts either commit statuses or checks

So we should be good.

well, our bot account is called bors, but the software behind it is actually homu

Turns out their the same thing!

@pocmo
Copy link
Contributor Author

pocmo commented Feb 5, 2019

This is kind of soft-blocked on utilizing the cache API: We need fast builds to make this work without causing more pain.

@jonalmeida
Copy link
Contributor

jonalmeida commented Feb 5, 2019 •
edited

There was a recommendation from the Rust #infra channel to use bors-ng which has taskcluster support already: https://github.com/bors-ng/bors-ng/blob/45de72ba106e0cabe7fddc4152c09e9c6adef83f/bors.toml#L1

Servo's bors config: https://github.com/servo/saltfs/blob/2a56d14c47d637dabe55c2f83a3088d35896cfc9/homu/files/cfg.toml#L286-L287

This is kind of soft-blocked on utilizing the cache API: We need fast builds to make this work without causing more pain.

Seems fair. I was curious about the tools required so I did some basic perusing. 😃

@pocmo
Copy link
Contributor Author

pocmo commented Aug 12, 2019

I played with bors-ng a bit in a different repository. This looks great and I think we should try it! I'll add this issue to the triage list. :)

pocmo added a commit to pocmo/android-components that referenced this issue Aug 12, 2019
@pocmo
Issue mozilla-mobile#1200: Add configuration for bors.
548da03
@pocmo pocmo mentioned this issue Aug 12, 2019
Merged
pocmo added a commit that referenced this issue Aug 12, 2019
@pocmo
Issue #1200: Add configuration for bors.
2cc3aed
@pocmo pocmo mentioned this issue Aug 12, 2019
Closed
@jonalmeida
Copy link
Contributor

https://i.giphy.com/media/5GoVLqeAOo6PK/giphy.webp

pocmo added a commit to pocmo/android-components that referenced this issue Aug 12, 2019
@pocmo
Issue mozilla-mobile#1200: .taskcluster.yml: Special case bors bot user.
f792995
pocmo added a commit that referenced this issue Aug 12, 2019
@pocmo
Issue #1200: .taskcluster.yml: Special case bors bot user.
284b533
@pocmo pocmo added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Aug 12, 2019
@pocmo pocmo self-assigned this Aug 12, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Aug 12, 2019
@pocmo
Issue mozilla-mobile#1200: Disable taskcluster checks for bors tmp br…
132ad73 
…anches.
bors bot pushed a commit that referenced this issue Aug 12, 2019
@MickeyMoz @pocmo
Merge #4099
5b1d98c 
4099: Issue #1200: Disable taskcluster checks for bors tmp branches. r=Amejia481 a=pocmo

Those branches are created temporarily and then deleted by bors. Running taskcluster tasks for them is a waste of energy and also slows down other tasks that are waiting for the resources.

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
pocmo added a commit to pocmo/android-components that referenced this issue Aug 12, 2019
@pocmo
Issue mozilla-mobile#1200: Add bors badge to README.
71ab021
bors bot pushed a commit that referenced this issue Aug 12, 2019
@MickeyMoz @pocmo
Merge #4099
64b47d5 
4099: Issue #1200: Disable taskcluster checks for bors tmp branches. r=Amejia481 a=pocmo

Those branches are created temporarily and then deleted by bors. Running taskcluster tasks for them is a waste of energy and also slows down other tasks that are waiting for the resources.

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
pocmo added a commit to pocmo/android-components that referenced this issue Aug 12, 2019
@pocmo
Issue mozilla-mobile#1200: Add marker to separate checklist from PR t…
a1f9612 
…ext (for bors).
bors bot pushed a commit that referenced this issue Aug 12, 2019
@MickeyMoz @pocmo
Merge #4100
d179647 
4100: Issue #1200: Add marker to separate checklist from PR text (for bors). r=Amejia481 a=pocmo



Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
@pocmo
Copy link
Contributor Author

pocmo commented Aug 13, 2019

Closing: Bors is running now. Let's see how it is going to be. :)

@pocmo pocmo closed this as completed Aug 13, 2019
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Aug 13, 2019
@pocmo pocmo added this to the 9.0.0 milestone Aug 13, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Aug 13, 2019
@pocmo
Issue mozilla-mobile#1200: Correctly order items in bors.toml.
b609e46
bors bot pushed a commit that referenced this issue Aug 14, 2019
@MickeyMoz @pocmo
Merge #4112
0a1ac23 
4112: Issue #1200: Correctly order items in bors.toml. r=jonalmeida a=pocmo

Oops. Accidentally added some config flags under the `commiter` group.



Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
rocketsroger pushed a commit to rocketsroger/android-components that referenced this issue Aug 14, 2019
@pocmo @rocketsroger
Issue mozilla-mobile#1200: Disable taskcluster checks for bors tmp br…
0e4f314 
…anches.
rocketsroger pushed a commit to rocketsroger/android-components that referenced this issue Aug 14, 2019
@pocmo @rocketsroger
Issue mozilla-mobile#1200: Add bors badge to README.
c0498be
rocketsroger pushed a commit to rocketsroger/android-components that referenced this issue Aug 14, 2019
@pocmo @rocketsroger
Issue mozilla-mobile#1200: Add marker to separate checklist from PR t…
c285d37 
…ext (for bors).
@pocmo pocmo mentioned this issue Aug 27, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
automation Build automation, Continuous integration, ..
Projects
No open projects
A-C: Android Components Sprint Planning
  
🏁 Done
Milestone
9.0.0 📷
Development

No branches or pull requests
2 participants
@pocmo @jonalmeida