Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add EngineView.getVersion()? #2349

Closed
psymoon opened this issue Mar 14, 2019 · 2 comments
Closed

Add EngineView.getVersion()? #2349

psymoon opened this issue Mar 14, 2019 · 2 comments
Assignees
Labels
<engine-gecko> Component: browser-engine-gecko <engine-system> Component: browser-engine-system (WebView) 🌟 feature New functionality and improvements 🐉 Fenix Feature needed for Fenix
Milestone

Comments

@psymoon
Copy link
Contributor

psymoon commented Mar 14, 2019

FFTV and focus (maybe fenix?) all display gecko (and possibly webview) version in the About page. We are currently exposing this through our BuildConfig in FFTV: https://github.com/mozilla-mobile/firefox-tv/blob/master/app/build.gradle#L253. Can this be added to EngineView?

┆Issue is synchronized with this Jira Task

@pocmo pocmo added 🌟 feature New functionality and improvements <engine-gecko> Component: browser-engine-gecko <engine-system> Component: browser-engine-system (WebView) labels Mar 14, 2019
@pocmo pocmo self-assigned this Jun 12, 2019
@pocmo
Copy link
Contributor

pocmo commented Jun 12, 2019

Picking this up. This will also be helpful for Fenix to keep features behind flags for certain engine versions; e.g. If feature X lands in GeckoView 70 then an app can create a feature flag to only enable this feature if GeckoView 70 is used.

@pocmo
Copy link
Contributor

pocmo commented Jun 12, 2019

GeckoView version numbers:

  • Release: 67.0.1
  • Beta: 68.0
  • Nightly: 69.0a1

@pocmo pocmo added the 🐉 Fenix Feature needed for Fenix label Jun 12, 2019
@pocmo pocmo added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Jun 12, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Jun 12, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Jun 12, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Jun 12, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Jun 14, 2019
@pocmo pocmo closed this as completed in 2318735 Jun 14, 2019
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Jun 14, 2019
@pocmo pocmo added this to the 1.0.0 milestone Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<engine-gecko> Component: browser-engine-gecko <engine-system> Component: browser-engine-system (WebView) 🌟 feature New functionality and improvements 🐉 Fenix Feature needed for Fenix
Projects
No open projects
Development

No branches or pull requests

2 participants