Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

App links: page action or menu option to open the current page in an external app #3695

Closed
jhugman opened this issue Jul 8, 2019 · 6 comments · Fixed by mozilla-mobile/fenix#4101

Comments

@jhugman
Copy link
Contributor

jhugman commented Jul 8, 2019

We can already detect if a URL is openable by a user-installed external app.

Show a page action and menu option to open the current page in that app.

Bonus: If the user has already selected a default, then show the app icon and name.

┆Issue is synchronized with this Jira Task

@jhugman jhugman added this to Backlog in A-C: Android Intent URLs Jul 8, 2019
@jhugman jhugman moved this from Backlog to Fenix Integration in A-C: Android Intent URLs Jul 8, 2019
@jhugman
Copy link
Contributor Author

jhugman commented Jul 10, 2019

@topotropic This is the simplest path forward. Where should this bit of UI go?

@jhugman jhugman added the blocked Blocked pull requests and issues label Jul 10, 2019
@jhugman
Copy link
Contributor Author

jhugman commented Jul 15, 2019

@topotropic have talked about this with @shortlander, re: using the existing permission prompts.

we considered using a similar UI as the one we use for permissions (bottom sheet) --- when you open permission.site with FF Preview and enable camera for example you can see it. Another idea that floated around was something simpler, like when you longpress on a link, open it in the background and see the snackbar that gives you the option to switch to the tab.

TL; DR

  1. use the existing permission style prompts
  2. use a snackbar.

@shorlander: do you have any preference?

@pocmo pocmo added this to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Jul 15, 2019
@jhugman
Copy link
Contributor Author

jhugman commented Jul 15, 2019

@shorlander : "Can we put this in a Quick Action Bar, perhaps using the app's icon".

Yes, but we'll also need a default icon when the user has not selected yet selected an app, and there are two non-browser apps available.

@jhugman
Copy link
Contributor Author

jhugman commented Jul 16, 2019

without app icon
with app icon

@jhugman jhugman moved this from Fenix Integration to In progress in A-C: Android Intent URLs Jul 16, 2019
@jhugman
Copy link
Contributor Author

jhugman commented Jul 16, 2019

in product without icon

@jhugman jhugman changed the title App links: page action and menu option to open the current page in an external app App links: page action or menu option to open the current page in an external app Jul 16, 2019
@jhugman jhugman removed the blocked Blocked pull requests and issues label Jul 16, 2019
A-C: Android Components Sprint Planning automation moved this from ⏳ Sprint Backlog to 🏁 Done Jul 18, 2019
@pocmo pocmo added this to the 5.0.0 🍃 milestone Jul 23, 2019
@jhugman jhugman moved this from In progress to Done in A-C: Android Intent URLs Jul 24, 2019
@abodea
Copy link
Member

abodea commented Jul 31, 2019

Hi @jhugman, I did some testing on the following websites/apps on the Latest Nightly build 7/31 using a Samsung Galaxy S10+(Android 9), Google Pixel 3a XL(Android 9).
I marked them with works/doesn't work meaning that the button Open in app appear or not on the website.
There are few websites that works correctly like your example with Reddit.
I have two questions:
It is fine do keep this bug for tracking all the examples below, or should I add another one in the Fenix repo regarding this issue?
Should we have for all websites a redirection to the play store in case we don't have the app installed?

For more details please see the information below:

Command Description/Status
Whatsapp Need to tap on "Get it on Google Play" resulting a redirect within the browser to the playstore, the "Open in App" is displayed and by pressing it you are redirected to the playstore app.
TikTok Doesn't work
Youtube Music Works
Youtube Works
Instagram Need to tap on "Get it on Google Play" resulting a redirect within the browser to the playstore, the "Open in App" is displayed and by pressing it you are redirected to the playstore app.
Facebook Doesn't work
Facebook Messenger Need to tap on "Get it on Google Play" resulting a redirect within the browser to the playstore, the "Open in App" is displayed and by pressing it you are redirected to the playstore app.
OLX Works
Pinterest Works
Netflix Doesn't work
Booking Doesn't work, from the the lower section of the page "Continue in the app" by tapping "Open App" redirects you to the Playstore app
AirBnb Works
Ebay List all new or modified files
AliExpress Doesn't work
AliBaba Doesn't work
Tumblr Works

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants