Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] The Spotify app is always opened when accessing any playlist from Fenix #4405

Closed
abodea opened this issue Jul 31, 2019 · 5 comments
Closed
Labels
🐞 bug Crashes, Something isn't working, .. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@abodea
Copy link
Member

abodea commented Jul 31, 2019

Steps to reproduce

  1. Launch Fenix.
  2. Access www.spotify.com.
  3. Login with valid credentials.
  4. Access any playlist from spotify.

Expected behavior

The playlist is correctly opened in fenix browser.

Actual behavior

Spotify app is opened every time when accessing a playlist on Fenix.

Device information

  • Android device: Samsung Galaxy s10+(Android 9).
  • Fenix version: Latest Nightly build 7/31.
    Video

┆Issue is synchronized with this Jira Task

@abodea abodea added 🐞 bug Crashes, Something isn't working, .. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Jul 31, 2019
@mcarare
Copy link
Contributor

mcarare commented Aug 1, 2019

@abodea IMO this is not a bug. This is a feature introduced in Android 6 which lets app open specific URLs without the open dialog. Spotify is default handler of links in spotify.com, open.spotify.com, accounts.spotify.com. Chrome and any other browser will have the same behaviour. This can be disabled only in device's system settings (see App Links).
I think this issue can be closed.

@abodea
Copy link
Member Author

abodea commented Aug 1, 2019

Hi @mcarare I added this bug based on this issue mozilla-mobile/android-components#3695.
It will be a feature for many websites that can be opened in external apps using the button from QAB.

@mcarare
Copy link
Contributor

mcarare commented Aug 1, 2019

IMO These are different issues and use cases. The feature you referenced is about opening a page in an app, via QAB, not handling a web link click, like in the issue you described here.

@Mugurell
Copy link
Contributor

Mugurell commented Aug 5, 2019

Clicking on a Spotify playlist, let's say
https://open.spotify.com/playlist/37i9dQZF1DXdPIbPNr916x
will result in a few redirects

the latter for which we would get an AppLinkRedirect like

AppLinkRedirect(appIntent=Intent { act=android.intent.action.VIEW cat=[android.intent.category.BROWSABLE] dat=spotify://user/spotify/playlist/37i9dQZF1DX3PFzdbtx1Us?adjust_reftag=csHngdU62eod1 pkg=com.spotify.music (has extras) }, webUrl=http://open.spotify.com/user/spotify/playlist/37i9dQZF1DX3PFzdbtx1Us?nd=1, isFallback=true)

which we'll then open in an external app.

Being that the Spotify website specifically sends us a deeplink to open the Spotify app I'd say the situation described here is not a bug but the intended behavior, and also the same behavior seen in other browsers for the same STRs.

@boek
Copy link
Contributor

boek commented Dec 28, 2019

This should be resolved with #3177

@boek boek closed this as completed Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Development

No branches or pull requests

4 participants