Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JEXL/CEL in fretboard to evaluate experiments? #454

Closed
pocmo opened this issue Jul 19, 2018 · 7 comments
Closed

Use JEXL/CEL in fretboard to evaluate experiments? #454

pocmo opened this issue Jul 19, 2018 · 7 comments

Comments

@pocmo
Copy link
Contributor

@pocmo pocmo commented Jul 19, 2018

In Fretboard/Switchboard we sometimes had the problem that we couldn't have more complex configurations because we can only match against certain properties (with Regex) and not write more complex rules involving AND, OR, >, <. Something like "Users with version 58 and higher" is already ridiculously complex when trying to express this as a regular expression that we match against the actual version number.

The desktop version of Firefox (SHIELD, Normandy) uses JEXL (Javascript Expression Language) for that purpose.

@pocmo
Copy link
Contributor Author

@pocmo pocmo commented Jul 20, 2018

@fercarcedo
Copy link
Contributor

@fercarcedo fercarcedo commented Jul 23, 2018

I can take a look at this and modify the evaluator

@pocmo
Copy link
Contributor Author

@pocmo pocmo commented Jul 24, 2018

@fercarcedo I think this is a rather big project. As far as I can see there's no implementation of JEXL in Java/Kotlin and this alone is a project in itself. Let's focus on the other fretboard tasks first. :)

@pocmo
Copy link
Contributor Author

@pocmo pocmo commented Jul 24, 2018

@pocmo
Copy link
Contributor Author

@pocmo pocmo commented Jul 25, 2018

Another option may be "Common Expression Language" (CEL):

@pocmo pocmo changed the title Use JEXL in fretboard to evaluate experiments? Use JEXL/CEL in fretboard to evaluate experiments? Jul 25, 2018
@mostlygeek
Copy link

@mostlygeek mostlygeek commented Aug 1, 2018

I also opened this on our side: mozilla/product-delivery#6 to track feedback / comments.

@pocmo
Copy link
Contributor Author

@pocmo pocmo commented Aug 10, 2018

I have been using some time here and there to write a Kotlin version of mozjexl. It's quite far already. I may hack a bit on that during my PTO next week because it's fun. I'll move this issue into the next sprint to share progress.

@pocmo pocmo added this to the 0.19 💈 milestone Aug 10, 2018
@pocmo pocmo self-assigned this Aug 10, 2018
@pocmo pocmo removed this from the 0.19 💈 milestone Aug 10, 2018
@pocmo pocmo added this to the 0.20 milestone Aug 10, 2018
@pocmo pocmo removed this from the 0.20 🎢 milestone Aug 24, 2018
@pocmo pocmo added this to the 0.21 milestone Aug 24, 2018
@pocmo pocmo removed this from the 0.21 👻 milestone Aug 31, 2018
@pocmo pocmo added this to the 0.22 🍄 milestone Aug 31, 2018
@pocmo pocmo removed this from the 0.22 🍄 milestone Sep 7, 2018
@pocmo pocmo added this to the 0.25 milestone Sep 7, 2018
@pocmo pocmo removed this from the 0.25 🐼 milestone Sep 26, 2018
@pocmo pocmo added this to the 0.26 milestone Sep 26, 2018
@pocmo pocmo removed this from the 0.26 🚴 milestone Oct 5, 2018
@pocmo pocmo added this to the 0.27 🕹 milestone Oct 5, 2018
pocmo added a commit to pocmo/android-components that referenced this issue Oct 8, 2018
…e - Context-based expression parser and evaluator.
pocmo added a commit to pocmo/android-components that referenced this issue Oct 8, 2018
…lished.
pocmo added a commit to pocmo/android-components that referenced this issue Oct 11, 2018
…e - Context-based expression parser and evaluator.
@csadilek csadilek removed this from the 0.27 🕹 milestone Oct 15, 2018
@csadilek csadilek added this to the 0.28 milestone Oct 15, 2018
pocmo added a commit to pocmo/android-components that referenced this issue Oct 17, 2018
…e - Context-based expression parser and evaluator.
pocmo added a commit to pocmo/android-components that referenced this issue Oct 17, 2018
…e - Context-based expression parser and evaluator.
pocmo added a commit to pocmo/android-components that referenced this issue Oct 17, 2018
…e - Context-based expression parser and evaluator.
pocmo added a commit to pocmo/android-components that referenced this issue Oct 17, 2018
…e - Context-based expression parser and evaluator.
pocmo added a commit to pocmo/android-components that referenced this issue Oct 17, 2018
…e - Context-based expression parser and evaluator.
csadilek added a commit that referenced this issue Oct 17, 2018
…sed expression parser and evaluator.
@pocmo pocmo closed this Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants