Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Use JEXL/CEL in fretboard to evaluate experiments? #454

Closed
pocmo opened this issue Jul 19, 2018 · 7 comments
Closed

Use JEXL/CEL in fretboard to evaluate experiments? #454

pocmo opened this issue Jul 19, 2018 · 7 comments
Assignees
Labels
🌟 feature New functionality and improvements 🔬 Research Problems without a solution that need research.
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented Jul 19, 2018

In Fretboard/Switchboard we sometimes had the problem that we couldn't have more complex configurations because we can only match against certain properties (with Regex) and not write more complex rules involving AND, OR, >, <. Something like "Users with version 58 and higher" is already ridiculously complex when trying to express this as a regular expression that we match against the actual version number.

The desktop version of Firefox (SHIELD, Normandy) uses JEXL (Javascript Expression Language) for that purpose.

┆Issue is synchronized with this Jira Task

@pocmo pocmo added 🌟 feature New functionality and improvements 🔬 Research Problems without a solution that need research. <fretboard> labels Jul 19, 2018
@pocmo
Copy link
Contributor Author

pocmo commented Jul 20, 2018

@fercarcedo
Copy link
Contributor

I can take a look at this and modify the evaluator

@pocmo
Copy link
Contributor Author

pocmo commented Jul 24, 2018

@fercarcedo I think this is a rather big project. As far as I can see there's no implementation of JEXL in Java/Kotlin and this alone is a project in itself. Let's focus on the other fretboard tasks first. :)

@pocmo
Copy link
Contributor Author

pocmo commented Jul 24, 2018

@pocmo
Copy link
Contributor Author

pocmo commented Jul 25, 2018

Another option may be "Common Expression Language" (CEL):

@pocmo pocmo changed the title Use JEXL in fretboard to evaluate experiments? Use JEXL/CEL in fretboard to evaluate experiments? Jul 25, 2018
@mostlygeek
Copy link

I also opened this on our side: mozilla/product-delivery#6 to track feedback / comments.

@pocmo
Copy link
Contributor Author

pocmo commented Aug 10, 2018

I have been using some time here and there to write a Kotlin version of mozjexl. It's quite far already. I may hack a bit on that during my PTO next week because it's fun. I'll move this issue into the next sprint to share progress.

@pocmo pocmo added this to the 0.19 💈 milestone Aug 10, 2018
@pocmo pocmo self-assigned this Aug 10, 2018
@pocmo pocmo modified the milestones: 0.19 💈, 0.20 Aug 10, 2018
@pocmo pocmo modified the milestones: 0.20 🎢, 0.21, 0.21 👻, 0.22 🍄 Aug 24, 2018
@pocmo pocmo modified the milestones: 0.22 🍄, 0.25 Sep 7, 2018
@pocmo pocmo modified the milestones: 0.25 🐼, 0.26 Sep 26, 2018
@pocmo pocmo modified the milestones: 0.26 🚴, 0.27 🕹 Oct 5, 2018
pocmo added a commit to pocmo/android-components that referenced this issue Oct 8, 2018
…e - Context-based expression parser and evaluator.
pocmo added a commit to pocmo/android-components that referenced this issue Oct 8, 2018
pocmo added a commit to pocmo/android-components that referenced this issue Oct 11, 2018
…e - Context-based expression parser and evaluator.
@csadilek csadilek modified the milestones: 0.27 🕹, 0.28 Oct 15, 2018
pocmo added a commit to pocmo/android-components that referenced this issue Oct 17, 2018
…e - Context-based expression parser and evaluator.
pocmo added a commit to pocmo/android-components that referenced this issue Oct 17, 2018
…e - Context-based expression parser and evaluator.
pocmo added a commit to pocmo/android-components that referenced this issue Oct 17, 2018
…e - Context-based expression parser and evaluator.
pocmo added a commit to pocmo/android-components that referenced this issue Oct 17, 2018
…e - Context-based expression parser and evaluator.
pocmo added a commit to pocmo/android-components that referenced this issue Oct 17, 2018
…e - Context-based expression parser and evaluator.
csadilek pushed a commit that referenced this issue Oct 17, 2018
@pocmo pocmo closed this as completed Oct 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🌟 feature New functionality and improvements 🔬 Research Problems without a solution that need research.
Projects
None yet
Development

No branches or pull requests

4 participants