Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Fennec migration: run in a foreground service #4879

Closed
grigoryk opened this issue Oct 29, 2019 · 3 comments
Closed

Fennec migration: run in a foreground service #4879

grigoryk opened this issue Oct 29, 2019 · 3 comments
Assignees
@pocmo @grigoryk
Labels
E8 Estimation points: 8 <migration> Component: support-migration
Projects
A-C: Android Components Sprint Planning Fennec migration
Milestone
25.0.0 ⛄️

Comments

@grigoryk
Copy link
Contributor

grigoryk commented Oct 29, 2019 •
edited by data-sync-user
Loading

Related to #4872 - our migrations are potentially slow, which creates a large window of time for things to go wrong (OS killing us, user killing us, some bad interaction with Fenix occuring, etc).

To get an additional margin of safety, we could wrap our migration code in a foreground service.

┆Issue is synchronized with this Jira Task
@grigoryk grigoryk added the <migration> Component: support-migration label Oct 29, 2019
@grigoryk grigoryk added this to Backlog in Fennec migration via automation Oct 29, 2019
@grigoryk grigoryk added this to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Nov 4, 2019
@grigoryk grigoryk moved this from ⏳ Sprint Backlog to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Nov 7, 2019
@pocmo
Copy link
Contributor

pocmo commented Nov 12, 2019

@grigoryk Are you working on this? Otherwise I may pick that up. :)

@grigoryk grigoryk added the E8 Estimation points: 8 label Nov 15, 2019
@pocmo pocmo self-assigned this Nov 18, 2019
@pocmo pocmo moved this from Backlog to In progress in Fennec migration Nov 18, 2019
@pocmo pocmo mentioned this issue Nov 25, 2019
Closed
pocmo added a commit to pocmo/android-components that referenced this issue Nov 25, 2019
@pocmo
Issue mozilla-mobile#4879: Add service for running migration in backg…
994b795 
…round.
pocmo added a commit to pocmo/android-components that referenced this issue Nov 26, 2019
@pocmo
Issue mozilla-mobile#4879: Add service for running migration in backg…
6383dfa 
…round.
pocmo added a commit to pocmo/android-components that referenced this issue Nov 27, 2019
@pocmo
Issue mozilla-mobile#4879: Add service for running migration in backg…
df37388 
…round.
bors bot pushed a commit that referenced this issue Nov 29, 2019
@MozLando @pocmo
Merge #5142
cf380a9 
5142: Issue #4879: Add service for running migration in background. r=grigoryk a=pocmo

This is the AC part of the background service. Next step is to open the Fenix PR after this is in the next snapshot.

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
pocmo added a commit to pocmo/fenix that referenced this issue Dec 9, 2019
@pocmo
Run migration in background service.
36e2258 
In order to avoid a half done migration we are moving the migration to a background service (that is
running the "foreground").

This is the Fenix part of:
mozilla-mobile/android-components#4879
pocmo added a commit to pocmo/fenix that referenced this issue Dec 9, 2019
@pocmo
Run migration in background service.
7aaf385 
In order to avoid a half done migration we are moving the migration to a background service (that is
running in the "foreground").

This is the Fenix part of:
mozilla-mobile/android-components#4879
@pocmo pocmo mentioned this issue Dec 9, 2019
Merged
grigoryk pushed a commit to pocmo/fenix that referenced this issue Dec 10, 2019
@pocmo
Run migration in background service.
41922b4 
In order to avoid a half done migration we are moving the migration to a background service (that is
running in the "foreground").

This is the Fenix part of:
mozilla-mobile/android-components#4879
bors bot pushed a commit to mozilla-mobile/fenix that referenced this issue Dec 10, 2019
@MozLando @pocmo
Merge #7034
b7fd4ed 
7034: Run migration in background service. r=grigoryk a=pocmo

In order to avoid a half done migration we are moving the migration to a background service (that is running in the "foreground").

This is the Fenix part of:
mozilla-mobile/android-components#4879

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
pocmo added a commit to pocmo/fenix that referenced this issue Dec 10, 2019
@pocmo
Run migration in background service.
0db75a1 
In order to avoid a half done migration we are moving the migration to a background service (that is
running in the "foreground").

This is the Fenix part of:
mozilla-mobile/android-components#4879
pocmo added a commit to mozilla-mobile/fenix that referenced this issue Dec 10, 2019
@pocmo
Run migration in background service.
a83717d 
In order to avoid a half done migration we are moving the migration to a background service (that is
running in the "foreground").

This is the Fenix part of:
mozilla-mobile/android-components#4879
@pocmo
Copy link
Contributor

pocmo commented Dec 10, 2019

Just landed in Fenix and should go into the next builds.

@pocmo pocmo closed this as completed Dec 10, 2019
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Dec 10, 2019
Fennec migration automation moved this from In progress to Ready for QA Dec 10, 2019
@pocmo pocmo added this to the 25.0.0 ⛄️ milestone Dec 10, 2019
@ebalazs-sv
Copy link

ebalazs-sv commented Dec 13, 2019 •
edited
Loading

Verified as fixed on Release, Beta, Nightly 12/13 migration builds with Pixel 3a XL (Android 10), Samsung Galaxy S8 (Android 9), Huawei Honor 8 (Android 7.0).
A notification is displayed while migration, and this contains:
warning sign Firefox Preview now
"Migrating" title
"Migrating user data." text
The notification disappears after the migration is done.

@ebalazs-sv ebalazs-sv moved this from Ready for QA to Done in Fennec migration Dec 13, 2019
sblatz pushed a commit to sblatz/android-components that referenced this issue Dec 19, 2019
@pocmo @sblatz
Issue mozilla-mobile#4879: Add service for running migration in backg…
a703a0d 
…round.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

@grigoryk grigoryk

Labels
E8 Estimation points: 8 <migration> Component: support-migration
Projects
No open projects
A-C: Android Components Sprint Planning
  
🏁 Done
Fennec migration
  
Done
Milestone
25.0.0 ⛄️
Development

No branches or pull requests
3 participants
@pocmo @grigoryk @ebalazs-sv