Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Fennec migration: The "Update complete" notification remains displayed until dismissed #5886

Closed
ebalazs-sv opened this issue Feb 11, 2020 · 3 comments
Closed

Fennec migration: The "Update complete" notification remains displayed until dismissed #5886

ebalazs-sv opened this issue Feb 11, 2020 · 3 comments
Assignees
@pocmo
Labels
🐞 bug Something isn't working <migration> Component: support-migration
Projects
Fennec migration
Milestone
33.0.0 🥙

Comments

@ebalazs-sv
Copy link

ebalazs-sv commented Feb 11, 2020 •
edited by data-sync-user
Loading

Preconditions:

Have Fennec installed.

Steps to reproduce

  1. Replace Fennec with Fenix;
  2. Launch Fenix;
  3. Observe the "Update complete" notification.

Expected behavior

The "Update complete" notification is dismissed.

Actual behavior

The "Update complete" notification is dismissed only by swipe.

Notes:

Video

Device information

  • Android device: Nexus 6P (Android 8.1.0);
  • Fenix version: Nightly migration build 8, 02/10.

┆Issue is synchronized with this Jira Task
@ebalazs-sv ebalazs-sv added <migration> Component: support-migration 🐞 bug Something isn't working labels Feb 11, 2020
@pocmo pocmo added this to Beta in Fennec migration Feb 11, 2020
@pocmo pocmo self-assigned this Feb 11, 2020
@pocmo pocmo moved this from Beta to In progress in Fennec migration Feb 13, 2020
pocmo added a commit to pocmo/android-components that referenced this issue Feb 13, 2020
@pocmo
Issue mozilla-mobile#5886: Add ability to dismiss "migration complete…
7270d04 
…d" notification.
@pocmo pocmo mentioned this issue Feb 13, 2020
Merged
pocmo added a commit to pocmo/fenix that referenced this issue Feb 13, 2020
@pocmo
Dismiss "migration notification" after leaving migration activity.
2232d0a 
For mozilla-mobile/android-components#5886.

With this patch we will dismiss the "migration completed" notification once the users
clicks on the button in the migration activity.
@pocmo pocmo mentioned this issue Feb 13, 2020
Merged
bors bot pushed a commit that referenced this issue Feb 13, 2020
@MozLando @pocmo
Merge #5927
e0274d8 
5927: Issue #5886: Add ability to dismiss "migration completed" notification. r=grigoryk a=pocmo

For #5886.

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
pocmo added a commit to pocmo/android-components that referenced this issue Feb 14, 2020
@pocmo
Issue mozilla-mobile#5886: Automatically cancel 'migration completed'…
4ea8694 
… notification after user clicks it.
@pocmo pocmo mentioned this issue Feb 14, 2020
Merged
pocmo added a commit to mozilla-mobile/fenix that referenced this issue Feb 14, 2020
@pocmo
Dismiss "migration notification" after leaving migration activity.
c45df6e 
For mozilla-mobile/android-components#5886.

With this patch we will dismiss the "migration completed" notification once the users
clicks on the button in the migration activity.
bors bot pushed a commit that referenced this issue Feb 17, 2020
@MozLando @pocmo
Merge #5935
ad1f778 
5935: Issue #5886: Automatically cancel 'migration completed' notification after user clicks it. r=grigoryk a=pocmo

Follow-up patch for #5886.

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
@pocmo
Copy link
Contributor

pocmo commented Feb 17, 2020

Will be fixed in the next Beta build.

@pocmo pocmo closed this as completed Feb 17, 2020
Fennec migration automation moved this from In progress to Ready for QA Feb 17, 2020
@pocmo pocmo added this to the 33.0.0 milestone Feb 17, 2020
@ebalazs-sv
Copy link
Author

I had tested this on Fennec Beta Migration 02/18 from https://github.com/mozilla-mobile/fenix/wiki/Fennec-Migration with Samsung Galaxy Note 8 (Android 9) and the "Update complete" notification is dismissed after is tapped once or when the "Start Firefox" button is tapped.
I will leave this on Ready for QA until it will be verified on the official Beta Migration build.

@LaurentiuApahideanSV
Copy link

Verified as fixed on Beta Migration Build #1, Firefox Preview Beta 74.0.0-beta.1 (Build #2015724883) using a Samsung Galaxy S5 (Android 6.0.1) and OnePlus 6T (Android 9). The "Update complete" notification is dismissed after tapping on it or the "Start Firefox" button.

@LaurentiuApahideanSV LaurentiuApahideanSV moved this from Ready for QA to Done in Fennec migration Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
🐞 bug Something isn't working <migration> Component: support-migration
Projects
No open projects
Fennec migration
  
Done
Milestone
33.0.0 🥙
Development

No branches or pull requests
3 participants
@pocmo @ebalazs-sv @LaurentiuApahideanSV