-
Notifications
You must be signed in to change notification settings - Fork 475
RegionSearchLocalizationProvider is slow on builds without MLS key #5989
Comments
Afaik you should also get a result with a dummy key - but it is rate limited. Are you sure you do not get anything back? 🤔 |
Oops! We were using an empty string. I will try a dummy key and close this out! |
@pocmo Is there a specific dummy key to use? I am getting this response |
I'll take a look. |
|
…MozillaLocationService implement it.
…MozillaLocationService implement it.
…MozillaLocationService implement it.
…MozillaLocationService implement it.
…MozillaLocationService implement it.
6021: Issue #5989: Create LocationService interface and make MozillaLocatioService implement it. r=jonalmeida a=pocmo 6082: Bug 1618128 - Import WebCompat 8.0.0 sources into feature-webcompat. r=pocmo a=denschub It's close to the end of a Gecko release cycle, which brings us to the end of the WebCompat release cycle. New version, wohoo! Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com> Co-authored-by: Dennis Schubert <dschubert@mozilla.com>
Workaround for issue described in: mozilla-mobile/android-components#5989 For debug builds it is unnecessary to use the actual location provider since those builds do not have an API key configured. With that patch we replace the location provider with a dummy implementation in debug builds.
Workaround for issue described in: mozilla-mobile/android-components#5989 For debug builds it is unnecessary to use the actual location provider since those builds do not have an API key configured. With that patch we replace the location provider with a dummy implementation in debug builds.
Workaround for issue described in: mozilla-mobile/android-components#5989 For debug builds it is unnecessary to use the actual location provider since those builds do not have an API key configured. With that patch we replace the location provider with a dummy implementation in debug builds.
MozillaLocationService.fetchRegion
caches a result, but if it doesn't get a result it will continue to to make that request every single time we use the RegionSearchLocalizationProvider┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: