Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add Profiler interface to support-base #7689

Closed
pocmo opened this issue Jul 13, 2020 · 3 comments · Fixed by #7776 or #7942
Closed

Add Profiler interface to support-base #7689

pocmo opened this issue Jul 13, 2020 · 3 comments · Fixed by #7776 or #7942
Assignees
@pocmo
Labels
<base> Component: concept-base, support-base E2 Estimation points: 2 <engine-gecko> Component: browser-engine-gecko
Projects
A-C: Android Components Sprint Planning
Milestone
58.0.0 🌽

Comments

@pocmo
Copy link
Contributor

pocmo commented Jul 13, 2020 •
edited by data-sync-user

Similar to CrashReporting let's create a Profiler interface to support-base. An Engine now exposes an optional Profiler... when using this from other components then we do not want to pass an Engine to everything, which would mean that everything depends on concept-engine. Instead let's create an interface in support-base.

Maybe it's even possible to move the Profiler interface from concept-engine ... since that is already an interface.

┆Issue is synchronized with this Jira Task
@pocmo pocmo added <engine-gecko> Component: browser-engine-gecko <base> Component: concept-base, support-base labels Jul 13, 2020
@pocmo pocmo self-assigned this Jul 13, 2020
@Amejia481 Amejia481 added this to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Jul 13, 2020
@Amejia481 Amejia481 added the E2 Estimation points: 2 label Jul 13, 2020
@pocmo
Copy link
Contributor Author

pocmo commented Jul 16, 2020

Hm, this is actually not as easy as I thought: Moving Profiler to support-base means that concept components (like concept-engine would need to depend on something that is not a concept. That seems wrong. We may need something like concept-base? Which may be a good place for other interfaces that currently live in support-base like CrashReporting or MemoryConsumer.

@csadilek What do you think?

@pocmo
Copy link
Contributor Author

pocmo commented Jul 20, 2020

Actually, I'll type an RFC for that :)

@pocmo pocmo linked a pull request Jul 20, 2020 that will close this issue
RFC: Adding a concept-base component for basic interfaces needed by multiple components. #7776
Merged
@csadilek
Copy link
Contributor

@csadilek What do you think?

Sorry, I missed this. Responded on the RFC PR :).

@pocmo pocmo removed this from ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Jul 27, 2020
@bors bors bot closed this as completed in #7776 Jul 31, 2020
@pocmo pocmo reopened this Jul 31, 2020
pocmo added a commit to pocmo/android-components that referenced this issue Jul 31, 2020
@pocmo
Issue mozilla-mobile#7689: Add concept-base component.
fe9cffb
pocmo added a commit to pocmo/android-components that referenced this issue Jul 31, 2020
@pocmo
Issue mozilla-mobile#7689: Move Profiler interface from concept-engin…
761abf1 
…e to concept-base.
@pocmo pocmo mentioned this issue Jul 31, 2020
Merged
@jonalmeida jonalmeida added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Aug 4, 2020
@data-sync-user data-sync-user changed the title Add Profiler interface to support-base FNX3-22811 ⁃ Add Profiler interface to support-base Aug 5, 2020
@st3fan st3fan changed the title FNX3-22811 ⁃ Add Profiler interface to support-base Add Profiler interface to support-base Aug 5, 2020
bors bot pushed a commit that referenced this issue Aug 24, 2020
@MozLando @pocmo
Merge #7942
8e25529 
7942: Introduce concept-base component. r=csadilek a=pocmo

As discussed in https://mozac.org/rfc/0003-concept-base-component.

Closes #7689.

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
pocmo added a commit to pocmo/android-components that referenced this issue Sep 8, 2020
@pocmo
Issue mozilla-mobile#7689: Add concept-base component.
e952b1c
pocmo added a commit to pocmo/android-components that referenced this issue Sep 8, 2020
@pocmo
Issue mozilla-mobile#7689: Move Profiler interface from concept-engin…
6edf116 
…e to concept-base.
bors bot pushed a commit that referenced this issue Sep 8, 2020
@MozLando @pocmo
Merge #7942
bb21c4e 
7942: Introduce concept-base component. r=csadilek a=pocmo

As discussed in https://mozac.org/rfc/0003-concept-base-component.

Closes #7689.

Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
@bors bors bot closed this as completed in 9d8bcc2 Sep 9, 2020
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Sep 9, 2020
@pocmo pocmo added this to the 58.0.0 🌽 milestone Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
<base> Component: concept-base, support-base E2 Estimation points: 2 <engine-gecko> Component: browser-engine-gecko
Projects
No open projects
A-C: Android Components Sprint Planning
  
🏁 Done
Milestone
58.0.0 🌽
3 participants
@pocmo @csadilek @Amejia481