Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Support new ContentDelegate#onExternalResponse(GeckoSession, WebResponse) api #8312

Closed
Amejia481 opened this issue Sep 1, 2020 · 0 comments
Closed

Support new ContentDelegate#onExternalResponse(GeckoSession, WebResponse) api #8312

Amejia481 opened this issue Sep 1, 2020 · 0 comments
Assignees
@Amejia481
Labels
⌨️ code Technical debt, code clean up, small API change .. E13 Estimation points: 13 🌟 feature New functionality and improvements
Projects
A-C: Android Components Sprint Planning
Milestone
62.0.0 🥮

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Sep 1, 2020 •
edited by data-sync-user 

v82
    ⚠️ Deprecated ContentDelegate#onExternalResponse(GeckoSession, WebResponseInfo) with the intention of removing them in GeckoView v85. (bug 1530022)
    Added ContentDelegate#onExternalResponse(GeckoSession, WebResponse) to eliminate the need to make a second request for downloads and ensure more efficient and reliable downloads in a single request. The second parameter is now a WebResponse (bug 1530022)

┆Issue is synchronized with this Jira Task
@Amejia481 Amejia481 added 🌟 feature New functionality and improvements ⌨️ code Technical debt, code clean up, small API change .. labels Sep 1, 2020
@Amejia481 Amejia481 self-assigned this Sep 1, 2020
@Amejia481 Amejia481 added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Sep 1, 2020
@Amejia481 Amejia481 changed the title Support new ContentDelegate#onExternalResponse(GeckoSession, WebResponse) Support new ContentDelegate#onExternalResponse(GeckoSession, WebResponse) api Sep 1, 2020
@Amejia481 Amejia481 added the E8 Estimation points: 8 label Sep 8, 2020
@Amejia481 Amejia481 mentioned this issue Sep 8, 2020
Closed
@Amejia481 Amejia481 moved this from 🏃‍♀️ In Progress to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Sep 9, 2020
This was referenced Sep 10, 2020
Closed
Closed
@Amejia481 Amejia481 moved this from ⏳ Sprint Backlog to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Sep 14, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 17, 2020
@Amejia481
Closes mozilla-mobile#8312:Adds support for ContentDelegate#onExterna…
da461a7 
…lResponse
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 18, 2020
@Amejia481
Closes mozilla-mobile#8312:Adds support for ContentDelegate#onExterna…
ab9d7e1 
…lResponse
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 18, 2020
@Amejia481
Closes mozilla-mobile#8312:Adds support for ContentDelegate#onExterna…
1f1d4f2 
…lResponse
@Amejia481 Amejia481 added E13 Estimation points: 13 and removed E8 Estimation points: 8 labels Sep 21, 2020
@pocmo pocmo added the blocked Blocked pull requests and issues label Sep 21, 2020
@Amejia481 Amejia481 moved this from 🏃‍♀️ In Progress to 🚷 Blocked in A-C: Android Components Sprint Planning Sep 23, 2020
@Amejia481 Amejia481 moved this from 🚷 Blocked to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Sep 28, 2020
@Amejia481 Amejia481 removed the blocked Blocked pull requests and issues label Sep 28, 2020
@Amejia481 Amejia481 moved this from ⏳ Sprint Backlog to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Sep 29, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 29, 2020
@Amejia481
Closes mozilla-mobile#8312:Adds support for ContentDelegate#onExterna…
ea490de 
…lResponse
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 29, 2020
@Amejia481
Closes mozilla-mobile#8312:Adds support for ContentDelegate#onExterna…
ee37b24 
…lResponse
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 29, 2020
@Amejia481
Closes mozilla-mobile#8312:Adds support for ContentDelegate#onExterna…
e0425e6 
…lResponse
@Amejia481 Amejia481 added this to the 62.0.0 🥮 milestone Oct 2, 2020
@Amejia481 Amejia481 moved this from 🏃‍♀️ In Progress to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Oct 2, 2020
@Amejia481 Amejia481 moved this from ⏳ Sprint Backlog to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Oct 5, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Oct 5, 2020
@Amejia481
Closes mozilla-mobile#8312:Adds support for ContentDelegate#onExterna…
8ac2a94 
…lResponse
@Amejia481 Amejia481 moved this from 🏃‍♀️ In Progress to ⏳ Review/QA in A-C: Android Components Sprint Planning Oct 5, 2020
@mergify mergify bot closed this as completed in 449abd4 Oct 5, 2020
A-C: Android Components Sprint Planning automation moved this from ⏳ Review/QA to 🏁 Done Oct 5, 2020
@data-sync-user data-sync-user mentioned this issue Jun 21, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
⌨️ code Technical debt, code clean up, small API change .. E13 Estimation points: 13 🌟 feature New functionality and improvements
Projects
No open projects
A-C: Android Components Sprint Planning
  
🏁 Done
Milestone
62.0.0 🥮
Development

No branches or pull requests
2 participants
@pocmo @Amejia481