Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Do not restart FAILED downloads #8354

Closed
Amejia481 opened this issue Sep 8, 2020 · 0 comments · Fixed by #8377
Closed

Do not restart FAILED downloads #8354

Amejia481 opened this issue Sep 8, 2020 · 0 comments · Fixed by #8377
Assignees
@Amejia481
Labels
🐞 bug Something isn't working E3 Estimation points: 3
Projects
A-C: Android Components Sprint Planning

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Sep 8, 2020 •
edited by data-sync-user

Related issue mozilla-mobile/fenix#14790, we need to add the failed downloads to the ignored list:

android-components/components/feature/downloads/src/main/java/mozilla/components/feature/downloads/DownloadMiddleware.kt

Line 113 in cd70260

if (download.status !in arrayOf(COMPLETED, CANCELLED)) {

┆Issue is synchronized with this Jira Task
@Amejia481 Amejia481 added the 🐞 bug Something isn't working label Sep 8, 2020
@Amejia481 Amejia481 self-assigned this Sep 8, 2020
@Amejia481 Amejia481 mentioned this issue Sep 8, 2020
Closed
@Amejia481 Amejia481 added the E3 Estimation points: 3 label Sep 8, 2020
@Amejia481 Amejia481 added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Sep 8, 2020
@Amejia481 Amejia481 moved this from 🏃‍♀️ In Progress to ⏳ Sprint Backlog in A-C: Android Components Sprint Planning Sep 8, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 10, 2020
@Amejia481
Close mozilla-mobile#8354: Do not restart FAILED downloads
9453db4
@Amejia481 Amejia481 moved this from ⏳ Sprint Backlog to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning Sep 11, 2020
@Amejia481 Amejia481 linked a pull request Sep 14, 2020 that will close this issue
Close #8354: Do not restart FAILED downloads #8377
Merged
4 tasks
bors bot pushed a commit that referenced this issue Sep 14, 2020
@MozLando @Amejia481
Merge #8377
dc3fff6 
8377: Close #8354: Do not restart FAILED downloads r=rocketsroger a=Amejia481



Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
@bors bors bot closed this as completed in 9a98bd2 Sep 14, 2020
A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
🐞 bug Something isn't working E3 Estimation points: 3
Projects
No open projects
A-C: Android Components Sprint Planning
  
🏁 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close #8354: Do not restart FAILED downloads Amejia481/android-components
1 participant
@Amejia481