Issue #1015: Enable an detekt rule for wrap blocks in { }

[vadimsemenov]

Closes #1015

[codecov]

Codecov Report

Merging #1040 into master will increase coverage by 0.04%.
The diff coverage is 62.5%.

@@             Coverage Diff              @@
##             master    #1040      +/-   ##
============================================
+ Coverage     79.67%   79.72%   +0.04%     
+ Complexity     1491     1488       -3     
============================================
  Files           194      194              
  Lines          5807     5805       -2     
  Branches        936      934       -2     
============================================
+ Hits           4627     4628       +1     
+ Misses          742      740       -2     
+ Partials        438      437       -1

Impacted Files	Coverage Δ	Complexity Δ
...illa/components/ui/progress/AnimatedProgressBar.kt	53.16% <0%> (+0.07%)	14 <0> (ø)	⬇️
...mponents/browser/engine/system/SystemEngineView.kt	82.65% <0%> (ø)	29 <0> (ø)	⬇️
...ervice/fretboard/source/kinto/SignatureVerifier.kt	78.02% <0%> (ø)	21 <0> (ø)	⬇️
.../browser/engine/system/matcher/ReversibleString.kt	81.48% <100%> (ø)	9 <2> (ø)	⬇️
...zilla/components/browser/session/SessionManager.kt	89.13% <100%> (ø)	73 <0> (ø)	⬇️
...mponents/browser/toolbar/display/DisplayToolbar.kt	89.1% <100%> (+1.28%)	34 <0> (-3)	⬇️
...tboard/source/kinto/HttpURLConnectionHttpClient.kt	88.88% <100%> (ø)	7 <0> (ø)	⬇️
...ents/ui/autocomplete/InlineAutocompleteEditText.kt	73.23% <50%> (ø)	42 <0> (ø)	⬇️
...ponents/browser/engine/system/matcher/WhiteList.kt	86.53% <60%> (ø)	19 <4> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94c984...2d945b9. Read the comment docs.

[pocmo]

Thank you. This looks great. I wonder where the asSequence() changes are coming from?

[pocmo]

Those two asSequence() changes seem unrelated?

[vadimsemenov]

I've noticed it because of IDEA inspection.

If we apply call chain on List, on each call new ArrayList will be created. So in worst case O((number of calls in chain) * (size of initial list)) aux memory will be allocated. asSequence fixes it and creates only (more on less) a new Sequence on each call.
It should improve both memory consumption and performance.

In case it seems unrelated, I can extract it to another pull request.
If you'd like me to do this, should I also extract fixes in documentation? As It seems equally unrelated to the original issue...

[vadimsemenov]

@pocmo I've run that inspection on the whole project and found another warning here:

android-components/components/service/fretboard/src/main/java/mozilla/components/service/fretboard/Fretboard.kt

Line 107 in 47bde0e

return experiments.filter { isInExperiment(context, ExperimentDescriptor(it.name)) }.toList()

So it may worth to extract it to separate issue and pull request. What do you think?

[vadimsemenov]

@pocmo, @Amejia481 any updates on this?