This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Extension functions for converting URLs to search terms #10480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csadilek
approved these changes
Jun 17, 2021
components/browser/state/src/main/java/mozilla/components/browser/state/search/SearchEngine.kt
Show resolved
Hide resolved
| import android.net.Uri | ||
|
|
||
| // OpenSearch parameter for search terms. | ||
| const val OS_SEARCH_ENGINE_TERMS_PARAM = "{" + "searchTerms" + "}" |
There was a problem hiding this comment.
nit: This could just be "{searchTerms}". :)
pocmo
reviewed
Jun 22, 2021
| return@fallback null | ||
| } | ||
| return currentEngine?.parseSearchTerms(parsedUrl) ?: fallback() | ||
| } |
There was a problem hiding this comment.
Note that this will not work for every search engine. Some (like Wikipedia) do a redirect and the resulting URL will not match the build URL anymore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge