Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Import strings from android-l10n. #11069

Merged
merged 3 commits into from
Oct 25, 2021

Conversation

mozilla-l10n-automation-bot
Copy link
Collaborator

n/t

@pocmo
Copy link
Contributor

pocmo commented Oct 7, 2021

build-browser-errorpages:

[task 2021-10-07T00:10:12.712Z] /builds/worker/checkouts/src/components/browser/errorpages/src/main/res/values-lo/strings.xml:190: Error: Replace "-" with an "en dash" character (–, –) ? [TypographyDashes]
[task 2021-10-07T00:10:12.713Z] ກວດເບິງເນັດເວີກຂອງທ່ານຄືນ ຫລື ລອງໂຫລດຫນ້າເວັບຄືນໃຫມ່ໃນອີກ 2-3 ນາທີ.

@Delphine Lint complains about the -. Do we care or should we disable this check?

@pocmo
Copy link
Contributor

pocmo commented Oct 7, 2021

Another error:

[task 2021-10-07T00:11:25.268Z] /builds/worker/checkouts/src/components/lib/crash/src/main/java/mozilla/components/lib/crash/prompt/CrashReporterActivity.kt:62: Error: Format string 'mozac_lib_crash_dialog_button_restart' is not a valid format string so it should not be passed to String.format [StringFormatInvalid]
[task 2021-10-07T00:11:25.268Z] text = getString(R.string.mozac_lib_crash_dialog_button_restart, appName)
[task 2021-10-07T00:11:25.268Z] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2021-10-07T00:11:25.268Z] /builds/worker/checkouts/src/components/lib/crash/src/main/res/values-ceb/strings.xml:14: This definition does not require arguments

Looks like mozac_lib_crash_dialog_button_restart in ceb does not contain the placeholder.

@Delphine
Copy link
Contributor

@pocmo We can disable that check since we do not impose rules on locales.
Also, I fixed the placeholder error for ceb locale :)
thanks!

@Delphine
Copy link
Contributor

@pocmo Is there anything else I can do to unblock this? Thanks

@pocmo
Copy link
Contributor

pocmo commented Oct 19, 2021

Pushed a commit to this PR to disable the TypographyDashes check. Now it should get merged.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@pocmo
Copy link
Contributor

pocmo commented Oct 19, 2021

Unrelated network failure on taskcluster. Restarting.

@Delphine
Copy link
Contributor

@pocmo Seems like this is still failing, and it's been 22 days that l10n can't be imported for a-c :/
Is there something we can do to fix this? thanks!

@pocmo
Copy link
Contributor

pocmo commented Oct 25, 2021

Looks like the L10N bot pushed over my commit. I'll add it again. :)

@pocmo pocmo added the 🛬 needs landing PRs that are ready to land label Oct 25, 2021
@mergify mergify bot merged commit f925bb9 into mozilla-mobile:main Oct 25, 2021
@Delphine
Copy link
Contributor

Thank you!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants