Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For #12061 - Add support to display AddressPicker #12142

Merged
merged 1 commit into from May 31, 2022
Merged

For #12061 - Add support to display AddressPicker #12142

merged 1 commit into from May 31, 2022

Conversation

Alexandru2909
Copy link
Contributor

@Alexandru2909 Alexandru2909 commented May 11, 2022 •
edited

Added support to display AddressPicker. Following the designs from here

Screenshot_20220511_184310

Screenshot_20220513_142727

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@gabrielluong gabrielluong self-requested a review May 11, 2022 14:48
@gabrielluong gabrielluong added the work in progress Not ready to land yet. Work in progress (WIP). label May 11, 2022
@Alexandru2909 Alexandru2909 marked this pull request as ready for review May 11, 2022 16:13
@Alexandru2909 Alexandru2909 added 🕵️‍♀️ needs review PRs that need to be reviewed and removed work in progress Not ready to land yet. Work in progress (WIP). labels May 11, 2022
@gabrielluong
Copy link
Member

Do you also have the Fenix side for this? We should make sure that this is only available if the Feature Flag is turned on.

@gabrielluong gabrielluong linked an issue May 12, 2022 that may be closed by this pull request
Add support to display an address picker to handle a SelectAddress request #12061
Closed
@Alexandru2909 Alexandru2909 changed the title For #12061 - Added support to display AddressPicker For #12061 - Add support to display AddressPicker May 13, 2022
@gabrielluong gabrielluong self-assigned this May 16, 2022
@mozilla-mobile mozilla-mobile deleted a comment from mergify bot May 18, 2022
@mcarare mcarare requested a review from gabrielluong May 26, 2022 08:15
@mcarare mcarare requested a review from Amejia481 May 26, 2022 08:15
@Alexandru2909 Alexandru2909 mentioned this pull request May 27, 2022
Closed
@Amejia481 Amejia481 mentioned this pull request May 30, 2022
Closed
4 tasks
gabrielluong
gabrielluong reviewed May 31, 2022
View reviewed changes
docs/changelog.md Outdated Show resolved Hide resolved
@Alexandru2909 Alexandru2909 added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels May 31, 2022
@mergify mergify bot merged commit f1bf2f1 into mozilla-mobile:main May 31, 2022
@Alexandru2909 Alexandru2909 mentioned this pull request May 31, 2022
Merged
3 tasks
@Alexandru2909 Alexandru2909 mentioned this pull request Nov 2, 2022
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabrielluong gabrielluong gabrielluong left review comments

@Amejia481 Amejia481 Amejia481 approved these changes

Assignees

@gabrielluong gabrielluong

Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to display an address picker to handle a SelectAddress request
3 participants
@Alexandru2909 @gabrielluong @Amejia481