Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Close #12926: Use external flag when opening fallback URL #12927

Merged
merged 1 commit into from Oct 11, 2022
Merged

Close #12926: Use external flag when opening fallback URL #12927

merged 1 commit into from Oct 11, 2022

Conversation

rocketsroger
Copy link
Contributor

@rocketsroger rocketsroger commented Oct 11, 2022 •
edited by github-actions bot

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Fixes #12926

@rocketsroger rocketsroger added the 🕵️‍♀️ needs review PRs that need to be reviewed label Oct 11, 2022
csadilek
csadilek approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rocketsroger rocketsroger added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed 🛬 needs landing PRs that are ready to land labels Oct 11, 2022
@mergify mergify bot merged commit c4ca929 into mozilla-mobile:main Oct 11, 2022
@rocketsroger rocketsroger deleted the AC_12926 branch October 11, 2022 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csadilek csadilek csadilek approved these changes

@Amejia481 Amejia481 Awaiting requested review from Amejia481 Amejia481 is a code owner

Assignees
No one assigned
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use external flag when opening fallback URL
2 participants
@rocketsroger @csadilek