Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

browser-engine-gecko-*: Explicitly set autofill flag. #2149

Merged
merged 1 commit into from Feb 21, 2019

Conversation

pocmo
Copy link
Contributor

@pocmo pocmo commented Feb 21, 2019

Fixes mozilla-mobile/fenix#617

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@pocmo pocmo added the 🕵️‍♀️ needs review PRs that need to be reviewed label Feb 21, 2019
@pocmo pocmo requested a review from a team as a code owner February 21, 2019 16:00
@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #2149 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2149      +/-   ##
============================================
- Coverage     84.88%   84.87%   -0.01%     
+ Complexity     2357     2350       -7     
============================================
  Files           279      279              
  Lines          9627     9621       -6     
  Branches       1418     1418              
============================================
- Hits           8172     8166       -6     
  Misses          872      872              
  Partials        583      583
Impacted Files Coverage Δ Complexity Δ
...illa/components/service/glean/BooleanMetricType.kt 93.33% <0%> (-1.91%) 10% <0%> (-7%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb2660...e6a6f5b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #2149 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2149      +/-   ##
============================================
- Coverage     84.88%   84.87%   -0.01%     
+ Complexity     2357     2350       -7     
============================================
  Files           279      279              
  Lines          9627     9621       -6     
  Branches       1418     1418              
============================================
- Hits           8172     8166       -6     
  Misses          872      872              
  Partials        583      583
Impacted Files Coverage Δ Complexity Δ
...illa/components/service/glean/BooleanMetricType.kt 93.33% <0%> (-1.91%) 10% <0%> (-7%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb2660...e6a6f5b. Read the comment docs.

Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants