Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #2332: Add WebAppManifestParser for creating WebAppManifest from JSON. #2339

Merged
merged 1 commit into from Mar 13, 2019

Conversation

pocmo
Copy link
Contributor

@pocmo pocmo commented Mar 13, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@pocmo pocmo added the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 13, 2019
@pocmo pocmo requested a review from a team as a code owner March 13, 2019 12:34
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #2339 into master will increase coverage by 0.1%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #2339     +/-   ##
===========================================
+ Coverage     83.42%   83.52%   +0.1%     
- Complexity     2637     2659     +22     
===========================================
  Files           320      321      +1     
  Lines         10933    11007     +74     
  Branches       1585     1591      +6     
===========================================
+ Hits           9121     9194     +73     
+ Misses         1153     1148      -5     
- Partials        659      665      +6
Impacted Files Coverage Δ Complexity Δ
...ponents/browser/session/manifest/WebAppManifest.kt 100% <100%> (+85.71%) 13 <0> (+12) ⬆️
...s/browser/session/manifest/WebAppManifestParser.kt 72.6% <72.6%> (ø) 2 <2> (?)
...illa/components/service/glean/LabeledMetricType.kt 88.67% <0%> (+0.74%) 24% <0%> (-1%) ⬇️
...illa/components/service/glean/BooleanMetricType.kt 95.23% <0%> (+1.9%) 17% <0%> (+9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab634b8...189977f. Read the comment docs.

Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@pocmo
Copy link
Contributor Author

pocmo commented Mar 13, 2019

Okay, updated PR. :)

@pocmo pocmo merged commit 966719f into mozilla-mobile:master Mar 13, 2019
@pocmo pocmo deleted the manifest-json branch March 13, 2019 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants