Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Issue #2340: Add component for landing PWA related code. #2343

Merged
merged 3 commits into from Mar 14, 2019

Conversation

pocmo
Copy link
Contributor

@pocmo pocmo commented Mar 13, 2019

An empty component to land code in :-)

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@pocmo pocmo added the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 13, 2019
@pocmo pocmo requested a review from a team as a code owner March 13, 2019 16:34
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #2343 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2343      +/-   ##
============================================
- Coverage      83.5%   83.48%   -0.03%     
- Complexity     2668     2675       +7     
============================================
  Files           322      324       +2     
  Lines         11011    11050      +39     
  Branches       1598     1601       +3     
============================================
+ Hits           9195     9225      +30     
- Misses         1148     1156       +8     
- Partials        668      669       +1
Impacted Files Coverage Δ Complexity Δ
.../java/org/mozilla/telemetry/net/TelemetryClient.kt 70% <0%> (ø) 3% <0%> (?)
...telemetry/measurement/ExperimentsMapMeasurement.kt 100% <0%> (ø) 4% <0%> (?)
...a/components/service/glean/error/ErrorRecording.kt 94.28% <0%> (+0.73%) 6% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af7e7c...0a63edc. Read the comment docs.

Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

components/feature/pwa/build.gradle Show resolved Hide resolved
@pocmo pocmo merged commit 086d7bf into mozilla-mobile:master Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants