This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fix #3293 Feed request URL to session observer from different engines #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
force-pushed
the
jhugman/3293-session-observer-sees-custom-scheme-urls
branch
from
1077df7
to
752419f
Compare
Amejia481
approved these changes
Jun 7, 2019
| fun onLoadRequest(session: Session, triggeredByRedirect: Boolean, triggeredByWebContent: Boolean) = Unit | ||
| fun onLoadRequest( | ||
| session: Session, | ||
| url: String, |
There was a problem hiding this comment.
nit: I think this is a breaking change, should it be added to the log change file?
This allows the slack:// (and other custom schemes).
jhugman
force-pushed
the
jhugman/3293-session-observer-sees-custom-scheme-urls
branch
from
752419f
to
4d2e5dc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the slack:// (and other custom schemes).
Fixes #3293.
Pull Request checklist
[ ] Changelog: This PR includes a changelog entry or does not need one[ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features