Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Remove GCP ping redirection for tagged pings. #3343

Merged
merged 2 commits into from Jun 28, 2019

Conversation

travis79
Copy link
Member

@travis79 travis79 commented Jun 10, 2019

This removes the redirection to GCP endpoint for all tagged pings

@travis79 travis79 requested a review from a team as a code owner June 10, 2019 19:49
@travis79 travis79 requested a review from Dexterp37 June 10, 2019 19:49
@travis79
Copy link
Member Author

@Dexterp37 I know that this doesn't have any documentation additions yet, putting this up for discussion.

@travis79 travis79 changed the title Remove GCP ping redirection for tagged pings Remove GCP ping redirection for tagged pings. Jun 10, 2019
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only change the endpoint, let's not overload tagging for other reasons. Moreover, let's land this after Fenix MVP .

@travis79 travis79 force-pushed the 1558278-debug-ping-endpoint branch from 6a72f21 to bfc1654 Compare June 11, 2019 12:31
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #3343 into master will increase coverage by 1.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3343      +/-   ##
============================================
+ Coverage     80.38%   81.72%   +1.34%     
- Complexity     2774     3217     +443     
============================================
  Files           382      405      +23     
  Lines         12544    13950    +1406     
  Branches       1871     2020     +149     
============================================
+ Hits          10083    11401    +1318     
- Misses         1700     1744      +44     
- Partials        761      805      +44
Impacted Files Coverage Δ Complexity Δ
...a/components/service/glean/net/HttpPingUploader.kt 95.45% <ø> (ø) 9 <0> (?)
...a/components/service/glean/config/Configuration.kt 100% <ø> (ø) 11 <0> (?)
...omponents/lib/publicsuffixlist/PublicSuffixList.kt 86.2% <0%> (-6.9%) 6% <0%> (ø)
...a/components/feature/app/links/AppLinksUseCases.kt 73.21% <0%> (-2.23%) 6% <0%> (+1%)
.../components/support/ktx/android/content/Context.kt 65.71% <0%> (-1.94%) 0% <0%> (ø)
...ts/concept/engine/manifest/WebAppManifestParser.kt 77.02% <0%> (-1.93%) 2% <0%> (-2%)
...ponents/feature/pwa/AbstractWebAppShellActivity.kt 20% <0%> (-1.74%) 3% <0%> (ø)
...mponents/browser/toolbar/display/DisplayToolbar.kt 92.14% <0%> (-0.88%) 45% <0%> (+3%)
...omponents/service/fxa/manager/FxaAccountManager.kt 87.3% <0%> (-0.82%) 34% <0%> (-3%)
...a/components/browser/search/SearchEngineManager.kt 89.18% <0%> (-0.56%) 17% <0%> (-1%)
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf1436...9f31591. Read the comment docs.

- This removes the redirection to GCP endpoint for all tagged pings.
- Fix tests depending on redirection of tagged pings.
@travis79 travis79 force-pushed the 1558278-debug-ping-endpoint branch from bfc1654 to 1edaffe Compare June 11, 2019 13:07
@travis79 travis79 requested a review from Dexterp37 June 11, 2019 13:36
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, thanks. Let's not merge this before 24th of June and, before doing that, let's check back with @pocmo and @akkomar . Can you please file a bug about doing the same for glean-core? :)

@travis79
Copy link
Member Author

This looks good to me now, thanks. Let's not merge this before 24th of June and, before doing that, let's check back with @pocmo and @akkomar . Can you please file a bug about doing the same for glean-core? :)

Follow-up bug for glean-core filed here

@travis79 travis79 merged commit 4f0bff2 into mozilla-mobile:master Jun 28, 2019
@travis79 travis79 deleted the 1558278-debug-ping-endpoint branch June 28, 2019 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants