Remove GCP ping redirection for tagged pings. #3343
Remove GCP ping redirection for tagged pings. #3343
Conversation
@Dexterp37 I know that this doesn't have any documentation additions yet, putting this up for discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should only change the endpoint, let's not overload tagging for other reasons. Moreover, let's land this after Fenix MVP .
components/service/glean/src/main/java/mozilla/components/service/glean/net/HttpPingUploader.kt
Outdated
Show resolved
Hide resolved
6a72f21
to
bfc1654
Compare
Codecov Report
@@ Coverage Diff @@
## master #3343 +/- ##
============================================
+ Coverage 80.38% 81.72% +1.34%
- Complexity 2774 3217 +443
============================================
Files 382 405 +23
Lines 12544 13950 +1406
Branches 1871 2020 +149
============================================
+ Hits 10083 11401 +1318
- Misses 1700 1744 +44
- Partials 761 805 +44
Continue to review full report at Codecov.
|
- This removes the redirection to GCP endpoint for all tagged pings. - Fix tests depending on redirection of tagged pings.
bfc1654
to
1edaffe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removes the redirection to GCP endpoint for all tagged pings