Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #3871: Autocomplete incorrectly fills urls that contains a port number. #3847

Merged
merged 1 commit into from Jul 23, 2019

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Jul 22, 2019

changed '/' position , after port number, in order to correctly show suggestions for addresses containing port numbers

Pull Request checklist

  • [ x] Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • [ ]x Changelog: This PR includes a changelog entry or does not need one
  • [ x] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.

@mcarare mcarare requested a review from a team as a code owner July 22, 2019 09:24
@pocmo pocmo added the 🕵️‍♀️ needs review PRs that need to be reviewed label Jul 23, 2019
@Amejia481 Amejia481 changed the title fixes #3983 in fenix - Autocomplete incorrectly fills urls that contain a port number. Closes #3983: Autocomplete incorrectly fills urls that contain a port number. Jul 23, 2019
@Amejia481 Amejia481 changed the title Closes #3983: Autocomplete incorrectly fills urls that contain a port number. Closes #3871: Autocomplete incorrectly fills urls that contain a port number. Jul 23, 2019
@Amejia481 Amejia481 changed the title Closes #3871: Autocomplete incorrectly fills urls that contain a port number. Closes #3871: Autocomplete incorrectly fills urls that contains a port number. Jul 23, 2019
@Amejia481
Copy link
Contributor

@Mihai-Adrian Before merging, I did some minimal changes.

@mcarare
Copy link
Contributor Author

mcarare commented Jul 23, 2019

Thank you, I will keep these in consideration for the future pull requests.

@Amejia481 Amejia481 merged commit 53b1a5d into mozilla-mobile:master Jul 23, 2019
@Amejia481
Copy link
Contributor

Thank you for the great job 🥇!

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #3847 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3847      +/-   ##
===========================================
+ Coverage     80.31%   80.6%   +0.28%     
- Complexity     3416    3613     +197     
===========================================
  Files           457     470      +13     
  Lines         15132   15738     +606     
  Branches       2269    2379     +110     
===========================================
+ Hits          12154   12685     +531     
- Misses         2046    2094      +48     
- Partials        932     959      +27
Impacted Files Coverage Δ Complexity Δ
.../mozilla/components/support/utils/DomainMatcher.kt 72.5% <100%> (ø) 0 <0> (ø) ⬇️
...ava/mozilla/components/support/utils/SafeBundle.kt 0% <0%> (-66.67%) 0% <0%> (-6%)
.../java/mozilla/components/support/ktx/kotlin/Map.kt 89.28% <0%> (-10.72%) 0% <0%> (ø)
...ava/mozilla/components/support/utils/SafeIntent.kt 67.44% <0%> (-5.06%) 22% <0%> (ø)
...ozilla/components/feature/prompts/PromptFeature.kt 91.79% <0%> (-2.29%) 30% <0%> (-3%)
...mozilla/components/feature/push/AutoPushFeature.kt 94.36% <0%> (-0.23%) 14% <0%> (-3%)
...n/java/mozilla/components/concept/fetch/Headers.kt 83.33% <0%> (ø) 0% <0%> (ø) ⬇️
...nents/browser/state/reducer/ContentStateReducer.kt 100% <0%> (ø) 9% <0%> (-2%) ⬇️
...lla/components/browser/state/state/ContentState.kt 100% <0%> (ø) 9% <0%> (-1%) ⬇️
...a/components/support/ktx/android/view/ViewGroup.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9675b29...9456510. Read the comment docs.

8 similar comments
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #3847 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3847      +/-   ##
===========================================
+ Coverage     80.31%   80.6%   +0.28%     
- Complexity     3416    3613     +197     
===========================================
  Files           457     470      +13     
  Lines         15132   15738     +606     
  Branches       2269    2379     +110     
===========================================
+ Hits          12154   12685     +531     
- Misses         2046    2094      +48     
- Partials        932     959      +27
Impacted Files Coverage Δ Complexity Δ
.../mozilla/components/support/utils/DomainMatcher.kt 72.5% <100%> (ø) 0 <0> (ø) ⬇️
...ava/mozilla/components/support/utils/SafeBundle.kt 0% <0%> (-66.67%) 0% <0%> (-6%)
.../java/mozilla/components/support/ktx/kotlin/Map.kt 89.28% <0%> (-10.72%) 0% <0%> (ø)
...ava/mozilla/components/support/utils/SafeIntent.kt 67.44% <0%> (-5.06%) 22% <0%> (ø)
...ozilla/components/feature/prompts/PromptFeature.kt 91.79% <0%> (-2.29%) 30% <0%> (-3%)
...mozilla/components/feature/push/AutoPushFeature.kt 94.36% <0%> (-0.23%) 14% <0%> (-3%)
...n/java/mozilla/components/concept/fetch/Headers.kt 83.33% <0%> (ø) 0% <0%> (ø) ⬇️
...nents/browser/state/reducer/ContentStateReducer.kt 100% <0%> (ø) 9% <0%> (-2%) ⬇️
...lla/components/browser/state/state/ContentState.kt 100% <0%> (ø) 9% <0%> (-1%) ⬇️
...a/components/support/ktx/android/view/ViewGroup.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9675b29...9456510. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #3847 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3847      +/-   ##
===========================================
+ Coverage     80.31%   80.6%   +0.28%     
- Complexity     3416    3613     +197     
===========================================
  Files           457     470      +13     
  Lines         15132   15738     +606     
  Branches       2269    2379     +110     
===========================================
+ Hits          12154   12685     +531     
- Misses         2046    2094      +48     
- Partials        932     959      +27
Impacted Files Coverage Δ Complexity Δ
.../mozilla/components/support/utils/DomainMatcher.kt 72.5% <100%> (ø) 0 <0> (ø) ⬇️
...ava/mozilla/components/support/utils/SafeBundle.kt 0% <0%> (-66.67%) 0% <0%> (-6%)
.../java/mozilla/components/support/ktx/kotlin/Map.kt 89.28% <0%> (-10.72%) 0% <0%> (ø)
...ava/mozilla/components/support/utils/SafeIntent.kt 67.44% <0%> (-5.06%) 22% <0%> (ø)
...ozilla/components/feature/prompts/PromptFeature.kt 91.79% <0%> (-2.29%) 30% <0%> (-3%)
...mozilla/components/feature/push/AutoPushFeature.kt 94.36% <0%> (-0.23%) 14% <0%> (-3%)
...n/java/mozilla/components/concept/fetch/Headers.kt 83.33% <0%> (ø) 0% <0%> (ø) ⬇️
...nents/browser/state/reducer/ContentStateReducer.kt 100% <0%> (ø) 9% <0%> (-2%) ⬇️
...lla/components/browser/state/state/ContentState.kt 100% <0%> (ø) 9% <0%> (-1%) ⬇️
...a/components/support/ktx/android/view/ViewGroup.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9675b29...9456510. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #3847 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3847      +/-   ##
===========================================
+ Coverage     80.31%   80.6%   +0.28%     
- Complexity     3416    3613     +197     
===========================================
  Files           457     470      +13     
  Lines         15132   15738     +606     
  Branches       2269    2379     +110     
===========================================
+ Hits          12154   12685     +531     
- Misses         2046    2094      +48     
- Partials        932     959      +27
Impacted Files Coverage Δ Complexity Δ
.../mozilla/components/support/utils/DomainMatcher.kt 72.5% <100%> (ø) 0 <0> (ø) ⬇️
...ava/mozilla/components/support/utils/SafeBundle.kt 0% <0%> (-66.67%) 0% <0%> (-6%)
.../java/mozilla/components/support/ktx/kotlin/Map.kt 89.28% <0%> (-10.72%) 0% <0%> (ø)
...ava/mozilla/components/support/utils/SafeIntent.kt 67.44% <0%> (-5.06%) 22% <0%> (ø)
...ozilla/components/feature/prompts/PromptFeature.kt 91.79% <0%> (-2.29%) 30% <0%> (-3%)
...mozilla/components/feature/push/AutoPushFeature.kt 94.36% <0%> (-0.23%) 14% <0%> (-3%)
...n/java/mozilla/components/concept/fetch/Headers.kt 83.33% <0%> (ø) 0% <0%> (ø) ⬇️
...nents/browser/state/reducer/ContentStateReducer.kt 100% <0%> (ø) 9% <0%> (-2%) ⬇️
...lla/components/browser/state/state/ContentState.kt 100% <0%> (ø) 9% <0%> (-1%) ⬇️
...a/components/support/ktx/android/view/ViewGroup.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9675b29...9456510. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #3847 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3847      +/-   ##
===========================================
+ Coverage     80.31%   80.6%   +0.28%     
- Complexity     3416    3613     +197     
===========================================
  Files           457     470      +13     
  Lines         15132   15738     +606     
  Branches       2269    2379     +110     
===========================================
+ Hits          12154   12685     +531     
- Misses         2046    2094      +48     
- Partials        932     959      +27
Impacted Files Coverage Δ Complexity Δ
.../mozilla/components/support/utils/DomainMatcher.kt 72.5% <100%> (ø) 0 <0> (ø) ⬇️
...ava/mozilla/components/support/utils/SafeBundle.kt 0% <0%> (-66.67%) 0% <0%> (-6%)
.../java/mozilla/components/support/ktx/kotlin/Map.kt 89.28% <0%> (-10.72%) 0% <0%> (ø)
...ava/mozilla/components/support/utils/SafeIntent.kt 67.44% <0%> (-5.06%) 22% <0%> (ø)
...ozilla/components/feature/prompts/PromptFeature.kt 91.79% <0%> (-2.29%) 30% <0%> (-3%)
...mozilla/components/feature/push/AutoPushFeature.kt 94.36% <0%> (-0.23%) 14% <0%> (-3%)
...n/java/mozilla/components/concept/fetch/Headers.kt 83.33% <0%> (ø) 0% <0%> (ø) ⬇️
...nents/browser/state/reducer/ContentStateReducer.kt 100% <0%> (ø) 9% <0%> (-2%) ⬇️
...lla/components/browser/state/state/ContentState.kt 100% <0%> (ø) 9% <0%> (-1%) ⬇️
...a/components/support/ktx/android/view/ViewGroup.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9675b29...9456510. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #3847 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3847      +/-   ##
===========================================
+ Coverage     80.31%   80.6%   +0.28%     
- Complexity     3416    3613     +197     
===========================================
  Files           457     470      +13     
  Lines         15132   15738     +606     
  Branches       2269    2379     +110     
===========================================
+ Hits          12154   12685     +531     
- Misses         2046    2094      +48     
- Partials        932     959      +27
Impacted Files Coverage Δ Complexity Δ
.../mozilla/components/support/utils/DomainMatcher.kt 72.5% <100%> (ø) 0 <0> (ø) ⬇️
...ava/mozilla/components/support/utils/SafeBundle.kt 0% <0%> (-66.67%) 0% <0%> (-6%)
.../java/mozilla/components/support/ktx/kotlin/Map.kt 89.28% <0%> (-10.72%) 0% <0%> (ø)
...ava/mozilla/components/support/utils/SafeIntent.kt 67.44% <0%> (-5.06%) 22% <0%> (ø)
...ozilla/components/feature/prompts/PromptFeature.kt 91.79% <0%> (-2.29%) 30% <0%> (-3%)
...mozilla/components/feature/push/AutoPushFeature.kt 94.36% <0%> (-0.23%) 14% <0%> (-3%)
...n/java/mozilla/components/concept/fetch/Headers.kt 83.33% <0%> (ø) 0% <0%> (ø) ⬇️
...nents/browser/state/reducer/ContentStateReducer.kt 100% <0%> (ø) 9% <0%> (-2%) ⬇️
...lla/components/browser/state/state/ContentState.kt 100% <0%> (ø) 9% <0%> (-1%) ⬇️
...a/components/support/ktx/android/view/ViewGroup.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9675b29...9456510. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #3847 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3847      +/-   ##
===========================================
+ Coverage     80.31%   80.6%   +0.28%     
- Complexity     3416    3613     +197     
===========================================
  Files           457     470      +13     
  Lines         15132   15738     +606     
  Branches       2269    2379     +110     
===========================================
+ Hits          12154   12685     +531     
- Misses         2046    2094      +48     
- Partials        932     959      +27
Impacted Files Coverage Δ Complexity Δ
.../mozilla/components/support/utils/DomainMatcher.kt 72.5% <100%> (ø) 0 <0> (ø) ⬇️
...ava/mozilla/components/support/utils/SafeBundle.kt 0% <0%> (-66.67%) 0% <0%> (-6%)
.../java/mozilla/components/support/ktx/kotlin/Map.kt 89.28% <0%> (-10.72%) 0% <0%> (ø)
...ava/mozilla/components/support/utils/SafeIntent.kt 67.44% <0%> (-5.06%) 22% <0%> (ø)
...ozilla/components/feature/prompts/PromptFeature.kt 91.79% <0%> (-2.29%) 30% <0%> (-3%)
...mozilla/components/feature/push/AutoPushFeature.kt 94.36% <0%> (-0.23%) 14% <0%> (-3%)
...n/java/mozilla/components/concept/fetch/Headers.kt 83.33% <0%> (ø) 0% <0%> (ø) ⬇️
...nents/browser/state/reducer/ContentStateReducer.kt 100% <0%> (ø) 9% <0%> (-2%) ⬇️
...lla/components/browser/state/state/ContentState.kt 100% <0%> (ø) 9% <0%> (-1%) ⬇️
...a/components/support/ktx/android/view/ViewGroup.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9675b29...9456510. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #3847 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3847      +/-   ##
===========================================
+ Coverage     80.31%   80.6%   +0.28%     
- Complexity     3416    3613     +197     
===========================================
  Files           457     470      +13     
  Lines         15132   15738     +606     
  Branches       2269    2379     +110     
===========================================
+ Hits          12154   12685     +531     
- Misses         2046    2094      +48     
- Partials        932     959      +27
Impacted Files Coverage Δ Complexity Δ
.../mozilla/components/support/utils/DomainMatcher.kt 72.5% <100%> (ø) 0 <0> (ø) ⬇️
...ava/mozilla/components/support/utils/SafeBundle.kt 0% <0%> (-66.67%) 0% <0%> (-6%)
.../java/mozilla/components/support/ktx/kotlin/Map.kt 89.28% <0%> (-10.72%) 0% <0%> (ø)
...ava/mozilla/components/support/utils/SafeIntent.kt 67.44% <0%> (-5.06%) 22% <0%> (ø)
...ozilla/components/feature/prompts/PromptFeature.kt 91.79% <0%> (-2.29%) 30% <0%> (-3%)
...mozilla/components/feature/push/AutoPushFeature.kt 94.36% <0%> (-0.23%) 14% <0%> (-3%)
...n/java/mozilla/components/concept/fetch/Headers.kt 83.33% <0%> (ø) 0% <0%> (ø) ⬇️
...nents/browser/state/reducer/ContentStateReducer.kt 100% <0%> (ø) 9% <0%> (-2%) ⬇️
...lla/components/browser/state/state/ContentState.kt 100% <0%> (ø) 9% <0%> (-1%) ⬇️
...a/components/support/ktx/android/view/ViewGroup.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9675b29...9456510. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #3847 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3847      +/-   ##
===========================================
+ Coverage     80.31%   80.6%   +0.28%     
- Complexity     3416    3613     +197     
===========================================
  Files           457     470      +13     
  Lines         15132   15738     +606     
  Branches       2269    2379     +110     
===========================================
+ Hits          12154   12685     +531     
- Misses         2046    2094      +48     
- Partials        932     959      +27
Impacted Files Coverage Δ Complexity Δ
.../mozilla/components/support/utils/DomainMatcher.kt 72.5% <100%> (ø) 0 <0> (ø) ⬇️
...ava/mozilla/components/support/utils/SafeBundle.kt 0% <0%> (-66.67%) 0% <0%> (-6%)
.../java/mozilla/components/support/ktx/kotlin/Map.kt 89.28% <0%> (-10.72%) 0% <0%> (ø)
...ava/mozilla/components/support/utils/SafeIntent.kt 67.44% <0%> (-5.06%) 22% <0%> (ø)
...ozilla/components/feature/prompts/PromptFeature.kt 91.79% <0%> (-2.29%) 30% <0%> (-3%)
...mozilla/components/feature/push/AutoPushFeature.kt 94.36% <0%> (-0.23%) 14% <0%> (-3%)
...n/java/mozilla/components/concept/fetch/Headers.kt 83.33% <0%> (ø) 0% <0%> (ø) ⬇️
...nents/browser/state/reducer/ContentStateReducer.kt 100% <0%> (ø) 9% <0%> (-2%) ⬇️
...lla/components/browser/state/state/ContentState.kt 100% <0%> (ø) 9% <0%> (-1%) ⬇️
...a/components/support/ktx/android/view/ViewGroup.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9675b29...9456510. Read the comment docs.

@mcarare mcarare deleted the 3983 branch December 17, 2019 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants