This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
For #5771: Changes description for a suggestion that represents an opened tab #5773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5773 +/- ##
===========================================
- Coverage 78.21% 76.9% -1.32%
+ Complexity 4476 165 -4311
===========================================
Files 588 29 -559
Lines 21242 1091 -20151
Branches 3079 172 -2907
===========================================
- Hits 16615 839 -15776
+ Misses 3368 201 -3167
+ Partials 1259 51 -1208
Continue to review full report at Codecov.
|
pocmo
reviewed
Feb 5, 2020
.../feature/awesomebar/src/main/java/mozilla/components/feature/awesomebar/AwesomeBarFeature.kt
Show resolved
Hide resolved
…presents an opened tab
ValentinTimisica
force-pushed
the
f-5771
branch
from
fd6ed85
to
1bcd447
Compare
pocmo
approved these changes
Feb 6, 2020
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2020
5773: For #5771: Changes description for a suggestion that represents an opened tab r=pocmo a=ValentinTimisica <!-- Text above this line will be added to the commit once "bors" merges this PR --> ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [x] **Tests**: This PR includes thorough tests. - [x] **Changelog**: This PR does not need [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md). - [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md). ### After merge - [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development. - [ ] **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser) to address the breaking issues. Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
Build failed
|
ValentinTimisica
changed the title
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2020
5773: For #5771: Changes description for a suggestion that represents an opened tab r=pocmo a=ValentinTimisica <!-- Text above this line will be added to the commit once "bors" merges this PR --> ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [x] **Tests**: This PR includes thorough tests. - [x] **Changelog**: This PR does not need [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md). - [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md). ### After merge - [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development. - [ ] **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser) to address the breaking issues. Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
Build succeeded
|
ValentinTimisica
added a commit
to ValentinTimisica/fenix
that referenced
this pull request
Feb 6, 2020
Change required for adding 'Switch to tab' description for a suggestion that represents an opened tab. Implemented in AC (mozilla-mobile/android-components#5773)
4 tasks
ValentinTimisica
added a commit
to ValentinTimisica/fenix
that referenced
this pull request
Feb 7, 2020
Change required for adding 'Switch to tab' description for a suggestion that represents an opened tab. Implemented in AC (mozilla-mobile/android-components#5773)
pocmo
pushed a commit
to mozilla-mobile/fenix
that referenced
this pull request
Feb 7, 2020
Change required for adding 'Switch to tab' description for a suggestion that represents an opened tab. Implemented in AC (mozilla-mobile/android-components#5773)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge